After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 796503 - A bug in basic-tutorial-13.c
A bug in basic-tutorial-13.c
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: documentation
1.14.1
Other Windows
: Normal minor
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-06-06 00:21 UTC by tomislavtustonic
Modified: 2018-06-14 05:12 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
A patch for basic-tutorial-13.c (414 bytes, patch)
2018-06-09 21:12 UTC, tomislavtustonic
committed Details | Review

Description tomislavtustonic 2018-06-06 00:21:53 UTC
It seems that there's a bug in the basic-tutorial-13.c, line 78, when data->rate is <0.

Here's an error shown:
GStreamer-CRITICAL **: gst_event_new_step: assertion 'rate > 0.0' failed

GStreamer-CRITICAL **: gst_element_send_event: assertion 'event != NULL' failed

According to the documentation (https://gstreamer.freedesktop.org/data/doc/gstreamer/head/gstreamer/html/GstEvent.html#gst-event-new-step) a rate of <= is not allowed.

It should probably be the absolute value of data->rate.
Comment 1 Sebastian Dröge (slomo) 2018-06-06 06:31:55 UTC
Yes, thanks for noticing. Do you want to provide a patch?
Comment 2 tomislavtustonic 2018-06-09 21:12:58 UTC
Created attachment 372625 [details] [review]
A patch for basic-tutorial-13.c
Comment 3 tomislavtustonic 2018-06-09 21:13:45 UTC
Hope this works. I don't have a c installed (nor do I care to install it ATM).
Comment 4 Sebastian Dröge (slomo) 2018-06-10 05:50:45 UTC
Thanks, will merge it later :)
Comment 5 Sebastian Dröge (slomo) 2018-06-13 07:59:24 UTC
Comment on attachment 372625 [details] [review]
A patch for basic-tutorial-13.c

commit 9b5958a22124c03cc8007e1353c511c5cc6a7aae (HEAD -> master)
Author: Tomislav Tustonic <tomislavtustonic@gmail.com>
Date:   Wed Jun 13 10:58:38 2018 +0300

    basic-tutorial-13: Step events need absolute values for the rate
    
    They can't change playback direction but are based on the current
    playback direction.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=796503
Comment 6 Sebastian Dröge (slomo) 2018-06-13 07:59:43 UTC
Also changed it in the text.
Comment 7 tomislavtustonic 2018-06-13 23:34:03 UTC
Could you also change it in code in the document (https://gstreamer.freedesktop.org/documentation/tutorials/basic/playback-speed.html)? For the people who read the documentation :) ?
Comment 8 Sebastian Dröge (slomo) 2018-06-14 05:12:09 UTC
(In reply to tomislavtustonic from comment #7)
> Could you also change it in code in the document
> (https://gstreamer.freedesktop.org/documentation/tutorials/basic/playback-
> speed.html)? For the people who read the documentation :) ?

That will happen automatically next time someone reruns the updater for that