After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 796490 - GESTimelineElement has some collisions between virtual methods and invokers
GESTimelineElement has some collisions between virtual methods and invokers
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-editing-services
unspecified
Other Linux
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-06-03 23:55 UTC by Corentin Noël
Modified: 2018-11-03 12:54 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Corentin Noël 2018-06-03 23:55:36 UTC
To make Vala happy, the invoker and virtual functions have to have to same prototype.
Here for GESTimelineElement, a possible approach would be to add a `gboolean` as return type of the invokers

The virtual methods:
```
  gboolean (*set_start)        (GESTimelineElement * self, GstClockTime start);
  gboolean (*set_inpoint)      (GESTimelineElement * self, GstClockTime inpoint);
  gboolean (*set_duration)     (GESTimelineElement * self, GstClockTime duration);
  gboolean (*set_max_duration) (GESTimelineElement * self, GstClockTime maxduration);
  gboolean (*set_priority)     (GESTimelineElement * self, guint32 priority);
```
The invokers:
```
GES_API
void ges_timeline_element_set_start                  (GESTimelineElement *self, GstClockTime start);
GES_API
void ges_timeline_element_set_inpoint                (GESTimelineElement *self, GstClockTime inpoint);
GES_API
void ges_timeline_element_set_duration               (GESTimelineElement *self, GstClockTime duration);
GES_API
void ges_timeline_element_set_max_duration           (GESTimelineElement *self, GstClockTime maxduration);
GES_API
void ges_timeline_element_set_priority               (GESTimelineElement *self, guint32 priority);
```
Comment 1 Thibault Saunier 2018-06-04 19:40:56 UTC
It should be safe to add gboolean as return values, patche welcome :-)
Comment 2 GStreamer system administrator 2018-11-03 12:54:15 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-editing-services/issues/38.