GNOME Bugzilla – Bug 796441
Meson Generates Erroneous MSVC Project Files For Build
Last modified: 2018-05-31 23:12:45 UTC
I mentioned I would post this on twitter a few days ago: https://twitter.com/TeFloatingBrain/status/1000150987678650380 I apologize for the unconventional manner of this but I am going to throw a link to the pastebin post here, it contains a list of problems and the steps I took to resolve them: https://pastebin.com/C2FzB9jm I will also attach to this my working build for static Orc-0.4.28 to this in case anyone wants to use it either for their project while the bug is resolved, or to fix the bug. One thing I did forget to mention is that #define isnan(x) _isnan(x) generates an error, but it seems to be fixed here: https://github.com/freedesktop/gstreamer-orc/commits/master
Created attachment 372452 [details] Working Build: https://nofile.io/f/ezMjzgryCyh/Orc428.zip
Created attachment 372453 [details] NON WORKING MESON FILES
Created attachment 372454 [details] Steps taken to generate meson files
Thanks for the bug report, but what would be more useful to is if you ignored everything you did based on 0.4.28 for now and just reported what doesn't work with git master for you?
(In reply to Tim-Philipp Müller from comment #4) > Thanks for the bug report, but what would be more useful to is if you > ignored everything you did based on 0.4.28 for now and just reported what > doesn't work with git master for you? Gotya. The static build seems to be a slight improvement. Building with --backend ninja still compiles with GCC (MinGW), and --backend MSVC the static build seems to target a .a extension. There is also the line #define ORC_API_EXPORT extern __attribute__ ((visibility ("default"))), if Im not mistaken the __attribute__ is a GCC language extension. It also is passing some GCC arguments (-fdiagnostics-color=always, -std=gnu99, -fvisibility=hidden). I replaced it with __declspec(dllexport) and everything compiled fine. It still passes the default arguments to the linker in addition to the default ones are already there. Also #define HAVE_SYS_TIME_H, #define HAVE_UNISTD_H are there which causes problems. Dynamic Builds and projects are config'd with it, and it seems to work on a couple executables I tested. Those small things aside everything seems to be working :)
Are you combining mingw with --backend MSVC by any chance? Are you running meson from within the visual studio environment cmd.exe (or set it up via vcvarsall.bat or whatever it's called? Please attach the meson log file from the run where it creates the export define with __attribute__ etc.
(In reply to Tim-Philipp Müller from comment #6) > Are you combining mingw with --backend MSVC by any chance? > > Are you running meson from within the visual studio environment cmd.exe (or > set it up via vcvarsall.bat or whatever it's called? > > Please attach the meson log file from the run where it creates the export > define with __attribute__ etc. Yes, when I build with --backend ninja it generates gcc makefiles. Im compiling from within the visual studio environment. Whats weird is it also passes MSVC flags to the linker as well as gcc flags to the compiler. *Attaching log*
Created attachment 372484 [details] Build with __attribute__
For future reference, when I said attach the log I meant the meson-log.txt file from the build directory, not a screenshot with dark blue text on dark blue background :) But in any case, I don't think this can be expected to work. You need to run meson --backend=vs2017 with cl.exe as compiler, otherwise everything will be terribly confused, as you noticed :) I think this is a meson bug though. It should probably not allow this.
I've filed https://github.com/mesonbuild/meson/issues/3648 as the upstream bug.
(In reply to Tim-Philipp Müller from comment #9) > For future reference, when I said attach the log I meant the meson-log.txt > file from the build directory, not a screenshot with dark blue text on dark > blue background :) > > But in any case, I don't think this can be expected to work. You need to run > meson --backend=vs2017 with cl.exe as compiler, otherwise everything will be > terribly confused, as you noticed :) > > I think this is a meson bug though. It should probably not allow this. Wups attached. :)
Created attachment 372497 [details] Meson Log For --backend vs2017
(In reply to Nirbheek Chauhan from comment #10) > I've filed https://github.com/mesonbuild/meson/issues/3648 as the upstream > bug. Cool beans :)