After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 796393 - soup: drop intltoolize
soup: drop intltoolize
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: cerbero
git master
Other Linux
: Normal normal
: 1.15.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-05-24 21:36 UTC by Tim-Philipp Müller
Modified: 2018-05-25 17:49 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
soup: drop intltoolize (1.43 KB, patch)
2018-05-24 21:36 UTC, Tim-Philipp Müller
committed Details | Review

Description Tim-Philipp Müller 2018-05-24 21:36:22 UTC
Created attachment 372393 [details] [review]
soup: drop intltoolize

intltool support was patched out in commit 1a456a9f, so this
should no longer be needed. Would fail like this on a
mingw cross-win64 build on debian 9.

[(36/44) libsoup -> configure ]
Running command 'gtkdocize && intltoolize --automake --copy && autoreconf --force --install --verbose'
/bin/sh: 1: intltoolize: not found
Recipe 'libsoup' failed at the build step 'configure'

Not tested elsewhere.
Comment 1 Nirbheek Chauhan 2018-05-25 17:44:17 UTC
Review of attachment 372393 [details] [review]:

lgtm
Comment 2 Tim-Philipp Müller 2018-05-25 17:49:18 UTC
And I forgot to add the bug link, but here it goes, let's see what breaks:

commit 99ce1b90e255bdc6914a6e18c0e945ded5f6c655 (HEAD -> master)
Author: Tim-Philipp Müller <tim@centricular.com>
Date:   Thu May 24 21:35:49 2018 +0100

    soup: drop intltoolize
    
    intltool support was patched out in commit 1a456a9f, so this
    should no longer be needed. Would fail like this on a
    mingw cross-win64 build on debian 9.4:
    
    [(36/44) libsoup -> configure ]
    Running command 'gtkdocize && intltoolize --automake --copy && autoreconf --force --install --verbose'
    /bin/sh: 1: intltoolize: not found
    Recipe 'libsoup' failed at the build step 'configure'