After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 796343 - Add macosx CI
Add macosx CI
Status: RESOLVED OBSOLETE
Product: glib
Classification: Platform
Component: build
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2018-05-22 19:13 UTC by Xavier Claessens
Modified: 2018-05-24 20:37 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add macosx CI (865 bytes, patch)
2018-05-22 19:14 UTC, Xavier Claessens 		needs-work Details | Review

Description Xavier Claessens 2018-05-22 19:13:46 UTC 
.
Comment 1 Xavier Claessens 2018-05-22 19:14:21 UTC 
Created attachment 372343 [details] [review]
Add macosx CI
Comment 2 Xavier Claessens 2018-05-22 19:18:05 UTC 
I have setup a macmini machine in Collabora Montreal office. It works on my personal gitlab repo:

https://gitlab.gnome.org/xclaesse/glib/-/jobs/35792

I just need admin rights on the GNOME/glib repo to get the CI token to setup the macmini on that repo.
Comment 3 Philip Withnall 2018-05-24 10:46:33 UTC 
(In reply to Xavier Claessens from comment #2)
> I just need admin rights on the GNOME/glib repo to get the CI token to setup
> the macmini on that repo.

File an infrastructure task (https://gitlab.gnome.org/Infrastructure/GitLab) and ask for a token. Would you be OK with setting the build machine up so any repo can use it? Or do you just want to limit it to GLib for now?
Comment 4 Philip Withnall 2018-05-24 10:52:22 UTC 
Review of attachment 372343 [details] [review]:

::: .gitlab-ci.yml
@@ +52,3 @@
       - "${CI_PROJECT_DIR}/_build/meson-logs"
 
+macosx:

I suggest `macos_10_7-meson-x86_64` to follow the current naming scheme (assuming this is a 10.7 machine, 64-bit).

@@ +55,3 @@
+  stage: build
+  tags:
+    - macosx

Which version of OS X is it running? GLib supports OS X ≥10.7, but some things only work with ≥10.9 (see https://wiki.gnome.org/Projects/GLib/SupportedPlatforms). I think it might make sense to mention the OS X version in the tag.

@@ +59,3 @@
+    - meson -Diconv=native _build
+    - ninja -C _build
+    # Multiple unit tests currently fails

This should be a FIXME, and please file a follow-up issue about fixing those failing unit tests.

@@ +60,3 @@
+    - ninja -C _build
+    # Multiple unit tests currently fails
+    - ninja -C _build test || true

It would be good to eventually get coverage support on OS X (just like we have on fedora-meson-x86_64), but that can happen in a follow-up bug unless you think it’s trivial to add now. (It might be!)
Comment 5 GNOME Infrastructure Team 2018-05-24 20:37:58 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/glib/issues/1389.