After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 796272 - gio: adjust annotation of GApplication's "open" signal
gio: adjust annotation of GApplication's "open" signal
Status: RESOLVED NOTGNOME
Product: gobject-introspection
Classification: Platform
Component: g-ir-scanner
unspecified
Other All
: Normal normal
: ---
Assigned To: gobject-introspection Maintainer(s)
gobject-introspection Maintainer(s)
https://gitlab.gnome.org/GNOME/gobjec...
Depends on:
Blocks:
 
 
Reported: 2018-05-20 11:51 UTC by Torsten Schoenfeld
Modified: 2018-05-21 12:36 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gio: adjust annotation of GApplication's "open" signal (1.01 KB, patch)
2018-05-20 11:51 UTC, Torsten Schoenfeld 		rejected Details | Review

Description Torsten Schoenfeld 2018-05-20 11:51:24 UTC 
Currently, the "files" argument is parsed as

          <parameter name="files" transfer-ownership="none">
            <doc xml:space="preserve">an array of #GFiles</doc>
            <array length="1" zero-terminated="0" c:type="gpointer">
              <type name="File"/>
            </array>
          </parameter>

That is, as a flat array of GFiles.  With the patch applied, it is parsed as

          <parameter name="files" transfer-ownership="none">
            <doc xml:space="preserve">an array of #GFiles</doc>
            <array length="1" zero-terminated="0" c:type="gpointer">
              <type name="File" c:type="gpointer"/>
            </array>
          </parameter>

That is, as an array of GFiles pointers.  This seems to be the correct parse.
Comment 1 Torsten Schoenfeld 2018-05-20 11:51:29 UTC 
Created attachment 372234 [details] [review]
gio: adjust annotation of GApplication's "open" signal

To ensure that the "files" argument is correctly represented as an array of
pointers, not as a flat array of structs.
Comment 2 Emmanuele Bassi (:ebassi) 2018-05-21 11:54:34 UTC 
Review of attachment 372234 [details] [review]:

I'm not overly fond of this.

GFile is an interface, which means it can only be a pointer type. This should likely be fixed in g-ir-scanner.
Comment 3 Philip Withnall 2018-05-21 12:07:07 UTC 
Review of attachment 372234 [details] [review]:

(In reply to Emmanuele Bassi (:ebassi) from comment #2)
> Review of attachment 372234 [details] [review] [review]:
> GFile is an interface, which means it can only be a pointer type. This
> should likely be fixed in g-ir-scanner.

Agreed.
Comment 4 Emmanuele Bassi (:ebassi) 2018-05-21 12:35:57 UTC 
g-i tracks bugs on GitLab.

Moving this issue there: https://gitlab.gnome.org/GNOME/gobject-introspection/issues/214