GNOME Bugzilla – Bug 796231
grl-thegamesdb.lua returns nil for games with multiple genres
Last modified: 2018-09-24 09:58:02 UTC
Created attachment 372169 [details] For the games with multiple genres, insert all values inside index 'genre' Currently the thegamesdb does not add genres to table media.genre for games with multiple genres.
Created attachment 372175 [details] [review] grl-thegamesdb: Allow thegamesdb to return multiple genres for games that have them
Review of attachment 372175 [details] [review]: This will need a test written as well.
Actually I left a print statement by mistake in the previous attachment. Sorry :( , I will update another attachment
Created attachment 372197 [details] [review] grl-thegamesdb: Allow thegamesdb to return multiple genres for games that have them
This is where the tests live: https://git.gnome.org/browse/grilo-plugins/tree/tests/games You'll need to add mock data for the request (a file that represents the output of the http request) in data/network-data.ini, and modify test_games.c to check that the output of the parsing is as expected.
Created attachment 372225 [details] [review] test: Add test to check multiple genre Currently thegamesdb only returns genre for games with a single genre. This test checks that thegamesdb returns multiple genres for the game Shatterhand.
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/grilo/issues/133.