After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 796211 - [review] lr/gapplication: turn the connection-editor it into a GtkApplication and more
[review] lr/gapplication: turn the connection-editor it into a GtkApplication...
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: nm-applet
unspecified
Other Linux
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks: nm-review
 
 
Reported: 2018-05-17 16:25 UTC by Lubomir Rintel
Modified: 2018-05-22 08:22 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Lubomir Rintel 2018-05-17 16:25:46 UTC 
This patch set turns the connection-editor into a GApplication.

The original motivation was to provide a Quit action with a usual Ctrl+Q accelerator in a way it's typically done, but it enables us to be able to drop the custom D-Bus code.

https://git.gnome.org/browse/network-manager-applet/log/?h=lr/gapplication
Comment 1 Thomas Haller 2018-05-18 09:14:37 UTC 
- it seems CTRL-Q does not work for me (on KDE)

- why did you open a new bug, instead of using https://bugzilla.redhat.com/show_bug.cgi?id=1539697 ?


Otherwise, lgtm!
Comment 2 Lubomir Rintel 2018-05-22 08:22:54 UTC 
> - it seems CTRL-Q does not work for me (on KDE)

Ah, the -appmenu.ui only gets loaded if the DE actually supports appmenu. Moved to menus.ui.

> - why did you open a new bug, instead of using https://bugzilla.redhat.com/show_bug.cgi?id=1539697 ?

Well, the scope of this seemed to go far beyond what the original bug asked, I didn't want to clutter it.

Merged in 67b2ff9cd9aa890dab22859a3e5f7677d927f7a8, the menus.ui fixup seemed trivial.