After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 796176 - eek, premature free
eek, premature free
Status: RESOLVED FIXED
Product: gdm
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GDM maintainers
GDM maintainers
Depends on:
Blocks:
 
 
Reported: 2018-05-16 18:08 UTC by Ray Strode [halfline]
Modified: 2018-05-16 18:08 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
display-access-file: fix early free (4.10 KB, patch)
2018-05-16 18:08 UTC, Ray Strode [halfline] 		committed Details | Review
display-access-file: drop unused function (8.29 KB, patch)
2018-05-16 18:08 UTC, Ray Strode [halfline] 		committed Details | Review

Description Ray Strode [halfline] 2018-05-16 18:08:08 UTC 
gdm_display_access_file_remove_display uses some variables after they're freed.
Comment 1 Ray Strode [halfline] 2018-05-16 18:08:16 UTC 
Created attachment 372128 [details] [review]
display-access-file: fix early free

The unused function gdm_display_access_file_remove_display frees
some variables and then tries to use them.

For completeness, this commit moves the free() calls to the
appropriate place in the code.

A subsequent commit will drop the function.
Comment 2 Ray Strode [halfline] 2018-05-16 18:08:19 UTC 
Created attachment 372129 [details] [review]
display-access-file: drop unused function

gdm_display_access_file_remove_display is unused.

This commit drops it.
Comment 3 Ray Strode [halfline] 2018-05-16 18:08:51 UTC 
Attachment 372128 [details] pushed as ae4ace0 - display-access-file: fix early free
Attachment 372129 [details] pushed as c405151 - display-access-file: drop unused function