After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 796109 - alsasrc: Don't use driver timestamp if it's zero
alsasrc: Don't use driver timestamp if it's zero
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal enhancement
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-05-14 15:09 UTC by Georg Lippitsch
Modified: 2018-11-03 12:07 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
alsasrc: Don't use driver timestamp if it's zero (1023 bytes, patch)
2018-05-14 15:14 UTC, Georg Lippitsch 		reviewed Details | Review

Description Georg Lippitsch 2018-05-14 15:09:51 UTC 
Some alsa sources (like dsnoop) have always zero in their timecode field. In that case, use gstreamer's own timestamping.
Comment 1 Georg Lippitsch 2018-05-14 15:14:06 UTC 
Created attachment 372026 [details] [review]
alsasrc: Don't use driver timestamp if it's zero
Comment 2 Sebastian Dröge (slomo) 2018-05-14 17:34:48 UTC 
Comment on attachment 372026 [details] [review]
alsasrc: Don't use driver timestamp if it's zero

You probably want to directly set driver_timestamps=FALSE in that case. If it reports once 0, it probably is not reliable ever
Comment 3 Nicolas Dufresne (ndufresne) 2018-05-15 10:06:16 UTC 
There is bunch of timestamp related information you can retrieve in ALSA API, which I'm not very familiar with. Have you made sure it's impossible to just ask the driver instead of just implementing this hack ?
Comment 4 Georg Lippitsch 2018-05-15 10:51:30 UTC 
I'm also not familiar with them. There is a bunch of different timestamps, but documentation is not at all clear what's the difference between them.

At least for get_htstamp() used by alsasrc, I didn't figure out how to check if they are valid. There is a snd_pcm_status_get_audio_htstamp_report(), but I have now idea how many thinks will break if I use get_audio_htstamp() instead of get_htstamp().
Comment 5 GStreamer system administrator 2018-11-03 12:07:19 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/issues/453.