After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 796103 - decklinksrc: Aggregate dropped frame/packet logging
decklinksrc: Aggregate dropped frame/packet logging
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal enhancement
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-05-14 13:42 UTC by Georg Lippitsch
Modified: 2018-11-03 14:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
decklinksrc: Aggregate dropped frame/packet logging (5.93 KB, patch)
2018-05-14 13:54 UTC, Georg Lippitsch 		none Details | Review
decklinksrc: Aggregate dropped frame/packet logging (6.33 KB, patch)
2018-05-15 11:04 UTC, Georg Lippitsch 		none Details | Review
decklinksrc: Aggregate dropped frame/packet logging (6.76 KB, patch)
2018-06-01 14:05 UTC, Georg Lippitsch 		none Details | Review

Description Georg Lippitsch 2018-05-14 13:42:56 UTC 
Decklinksrc currently prints a log entry for every dropped frame and audio packet. That completely spams the log file.

Attached patch aggregates information about dropped packets and only prints a message when dropping starts, and a summary when dropping ends.
Comment 1 Georg Lippitsch 2018-05-14 13:54:19 UTC 
Created attachment 372013 [details] [review]
decklinksrc: Aggregate dropped frame/packet logging
Comment 2 Sebastian Dröge (slomo) 2018-05-14 17:38:39 UTC 
Review of attachment 372013 [details] [review]:

::: sys/decklink/gstdecklinkvideosrc.cpp
@@ +267,3 @@
+  self->skipped_last = 0;
+  self->skip_from_timestamp = GST_CLOCK_TIME_NONE;
+  self->skip_to_timestamp = GST_CLOCK_TIME_NONE;

These should also be reset in GST_STATE_CHANGE_NULL_TO_READY
Comment 3 Georg Lippitsch 2018-05-15 11:04:20 UTC 
Created attachment 372069 [details] [review]
decklinksrc: Aggregate dropped frame/packet logging
Comment 4 Sebastian Dröge (slomo) 2018-05-15 13:50:37 UTC 
Review of attachment 372069 [details] [review]:

::: sys/decklink/gstdecklinkvideosrc.cpp
@@ +1236,3 @@
+      self->skipped_last = 0;
+      self->skip_from_timestamp = GST_CLOCK_TIME_NONE;
+      self->skip_to_timestamp = GST_CLOCK_TIME_NONE;

And the same for the audio source of course :)
Comment 5 Sebastian Dröge (slomo) 2018-05-15 13:52:05 UTC 
Review of attachment 372069 [details] [review]:

::: sys/decklink/gstdecklinkvideosrc.cpp
@@ +1236,3 @@
+      self->skipped_last = 0;
+      self->skip_from_timestamp = GST_CLOCK_TIME_NONE;
+      self->skip_to_timestamp = GST_CLOCK_TIME_NONE;

And the same for the audio source of course :)
Comment 6 Georg Lippitsch 2018-06-01 14:05:02 UTC 
Created attachment 372509 [details] [review]
decklinksrc: Aggregate dropped frame/packet logging
Comment 7 GStreamer system administrator 2018-11-03 14:22:56 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/issues/705.