GNOME Bugzilla – Bug 796072
[PATCH] Fix tests/ff-load-save/Makefile.am for --without-gexiv2
Last modified: 2018-05-13 16:53:44 UTC
Created attachment 371974 [details] [review] Proposed patch for tests/ff-load-save/Makefile.am respecting --without-gexiv2 Hi! I just learned that --with-libavformat makes the test suite rely on examples/gegl-video being built (see tests/ff-load-save/Makefile.am) but examples/gegl-video is only built if --with-gexiv2 was passed as well (see examples/Makefile.am). So with these two flags, one out of four combinations makes the test suite fail at the moment. Please consider the patch attached for a fix. Here's what the error looks like on the shell, in isolation: $ ./autogen.sh --without-gexiv2 --with-libavformat && make && make -C tests/ff-load-save/ images [..] make: Entering directory '/tmp/tmp.SvD0Uekgs3/gegl/tests/ff-load-save' for a in *.avi *.mp4 *.ogv ;do \ GEGL_PATH=../../operations ../../examples/gegl-video \ $a -s 74 -e 74 -of $a- ;\ done /bin/sh: line 1: ../../examples/gegl-video: No such file or directory /bin/sh: line 1: ../../examples/gegl-video: No such file or directory /bin/sh: line 1: ../../examples/gegl-video: No such file or directory make: *** [Makefile:599: images] Error 127 make: Leaving directory '/tmp/tmp.SvD0Uekgs3/gegl/tests/ff-load-save' Best Sebastian PS: For the original bug report in Gentoo, please see https://bugs.gentoo.org/655646
Thank you, patch applied in git master commit 53e0672121a77249f32db16c96c837ba7bf19e73 Author: Sebastian Pipping <sebastian@pipping.org> Date: Sun May 13 18:32:33 2018 +0200 Run ff-load-save image tests only when gegl-video is around