After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 795970 - waylandsink: Don't create throwaway empty regions
waylandsink: Don't create throwaway empty regions
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-05-09 13:00 UTC by Daniel Stone
Modified: 2018-11-03 14:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
waylandsink: Don't create throwaway empty regions (1.55 KB, patch)
2018-05-09 13:02 UTC, Daniel Stone 		accepted-commit_now Details | Review

Description Daniel Stone 2018-05-09 13:00:25 UTC 
Any argument annotated with allow-null="true" in the Wayland protocol can have literal NULL passed to it.
Comment 1 Daniel Stone 2018-05-09 13:02:17 UTC 
Created attachment 371840 [details] [review]
waylandsink: Don't create throwaway empty regions

Instead of creating a region, adding nothing to it, setting that as the
input region and destroying the region, you can instead just pass NULL
to wl_surface_set_input_region for the same effect.
Comment 2 Nicolas Dufresne (ndufresne) 2018-05-10 14:18:50 UTC 
Review of attachment 371840 [details] [review]:

Ah, that is good to know, thanks. George and I a on vacation, feel free to merge anyone.
Comment 3 GStreamer system administrator 2018-11-03 14:22:38 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/issues/702.