GNOME Bugzilla – Bug 795965
installed libnm/NetworkManager.h: #includes uninstalled nm-autoptr.h
Last modified: 2018-05-11 16:21:31 UTC
NetworkManager-1.11.3 with meson installs libnm/NetworkManager.h as /usr/loca/libnm/NetworkManager.h . Its 111st line is "#include nm-autoptr.h", but nm-autoptr.h is not installed. gnome-shell tryes to #include libnm/NetworkManager.h and fails finding nm-autoptr.h: gnome-shell-3.28.2/build$ ninja Compiling C object 'src/src@@gnome-shell@sha/meson-generated_.._shell-enum-types.c.o'. FAILED: src/src@@gnome-shell@sha/meson-generated_.._shell-enum-types.c.o cc -Isrc/src@@gnome-shell@sha -Isrc -I../src -I. -I../ -Isrc/st -I../src/st -Isrc/st/.. -I../src/st/.. -Isrc/tray -I../src/tray -Ijs -I/usr/local/include/gio-unix-2.0/ -I/usr/local/include/glib-2.0 -I/usr/local /lib/glib-2.0/include -I/usr/local/include -I/usr/local/include/libxml2 -I/usr/local/include/at-spi2-atk/2.0 -I/usr/local/include/at-spi-2.0 -I/usr/include/dbus-1.0 -I/usr/lib/dbus-1.0/include -I/usr/local/incl ude/gtk-3.0 -I/usr/local/include/pango-1.0 -I/usr/local/include/fribidi -I/usr/local/include/atk-1.0 -I/usr/local/include/cairo -I/usr/local/include/pixman-1 -I/usr/local/include/freetype2 -I/usr/local/include/ harfbuzz -I/usr/local/include/libdrm -I/usr/local/include/gdk-pixbuf-2.0 -I/usr/local/include/libpng16 -I/usr/include/uuid -I/usr/local/include/gjs-1.0 -I/usr/local/include/gobject-introspection-1.0 -I/usr/loca l/lib/libffi-3.2.1/include -I/usr/local/include/mozjs-52 -I/usr/local/include/nspr -I/usr/local/include/libsoup-2.4 -I/usr/local/include/mutter/clutter-2 -I/include -I/usr/local/include/json-glib-1.0 -I/usr/loc al/include/mutter/cogl -I/usr/local/include/startup-notification-1.0 -I/usr/local/include/polkit-1 -I/usr/local/include/gcr-3 -I/usr/local/include/gck-1 -I/usr/local/include/p11-kit-1 -I/usr/local/include/libnm -I/usr/local/include/libsecret-1 -I/usr/local/include/gstreamer-1.0 -I/usr/local/include/mutter -I/usr/local/include/gsettings-desktop-schemas -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Win valid-pch -O0 -g -fPIC -pthread -D_REENTRANT -include /usr/local/include/mozjs-52/js/RequiredDefines.h -DCLUTTER_ENABLE_EXPERIMENTAL_API -DCOGL_ENABLE_EXPERIMENTAL_API '-DVERSION="3.28.2"' '-DLOCALEDIR="/usr/lo cal/share/locale"' '-DDATADIR="/usr/local/share"' '-DGNOME_SHELL_LIBEXECDIR="/usr/local/libexec"' '-DGNOME_SHELL_DATADIR="/usr/local/share/gnome-shell"' '-DGNOME_SHELL_PKGLIBDIR="/usr/local/lib64/gnome-shell"' -MD -MQ 'src/src@@gnome-shell@sha/meson-generated_.._shell-enum-types.c.o' -MF 'src/src@@gnome-shell@sha/meson-generated_.._shell-enum-types.c.o.d' -o 'src/src@@gnome-shell@sha/meson-generated_.._shell-enum-ty pes.c.o' -c src/shell-enum-types.c In file included from ../src/shell-network-agent.h:7:0, from src/shell-enum-types.c:24: /usr/local/include/libnm/NetworkManager.h:111:10: fatal error: nm-autoptr.h: No such file or directory #include "nm-autoptr.h" ^~~~~~~~~~~~~~ compilation terminated. ninja: build stopped: subcommand failed.
Created attachment 371879 [details] [review] [PATCH] build: meson: add missing nm-autoptr.h to libnm headers
(In reply to Beniamino Galvani from comment #1) > Created attachment 371879 [details] [review] [review] > [PATCH] build: meson: add missing nm-autoptr.h to libnm headers lgtm
Applied to master: https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=db80d5f62a1edf39c5970887ef7b9ec62dd4163f