After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 795947 - css.lang: Prefix/suffix for colors and property values too restrictive / not necessary
css.lang: Prefix/suffix for colors and property values too restrictive / not ...
Status: RESOLVED FIXED
Product: gtksourceview
Classification: Platform
Component: Syntax files
git master
Other Linux
: Normal normal
: ---
Assigned To: GTK Sourceview maintainers
GTK Sourceview maintainers
Depends on:
Blocks:
 
 
Reported: 2018-05-08 18:49 UTC by Jeffery To
Modified: 2018-05-09 11:04 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
css.lang: Remove prefix/suffix for colors and property values (2.41 KB, patch)
2018-05-08 18:54 UTC, Jeffery To
none Details | Review

Description Jeffery To 2018-05-08 18:49:55 UTC
The color and property value contexts have a prefix and suffix that causes these to not be highlighted correctly:

color:aqua;
float: left!important;

Will attach a patch shortly.
Comment 1 Jeffery To 2018-05-08 18:54:47 UTC
Created attachment 371815 [details] [review]
css.lang: Remove prefix/suffix for colors and property values

A space before or after a color or property value is not required, and normal keyword matching will ensure there are word boundaries before and after the keyword, so the prefix and suffix are not necessary.
Comment 2 Sébastien Wilmet 2018-05-09 11:04:49 UTC
Thanks, pushed as commit 366fb3a408e5f0240b82b3919537962a8a28b481.