After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 795943 - thegamesdb: Add Virtual Boy support
thegamesdb: Add Virtual Boy support
Status: RESOLVED FIXED
Product: grilo
Classification: Other
Component: plugins
unspecified
Other Linux
: Normal normal
: ---
Assigned To: grilo-maint
grilo-maint
Depends on:
Blocks:
 
 
Reported: 2018-05-08 18:11 UTC by Alexander Mikhaylenko
Modified: 2018-05-28 06:35 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
thegamesdb: Add Virtual Boy support (1.08 KB, patch)
2018-05-08 18:11 UTC, Alexander Mikhaylenko 		none Details | Review
thegamesdb: Add Virtual Boy support (1.15 KB, patch)
2018-05-08 18:13 UTC, Alexander Mikhaylenko 		accepted-commit_now Details | Review

Description Alexander Mikhaylenko 2018-05-08 18:11:27 UTC 
See the patch.
Comment 1 Alexander Mikhaylenko 2018-05-08 18:11:58 UTC 
Created attachment 371812 [details] [review]
thegamesdb: Add Virtual Boy support
Comment 2 Alexander Mikhaylenko 2018-05-08 18:13:54 UTC 
Created attachment 371813 [details] [review]
thegamesdb: Add Virtual Boy support

Support Virtual Boy games via 'application/x-virtual-boy-rom' MIME type.
Comment 3 Bastien Nocera 2018-05-08 20:34:44 UTC 
Review of attachment 371813 [details] [review]:

Looks good if you've actually tested this.
Comment 4 Alexander Mikhaylenko 2018-05-08 20:57:52 UTC 
Yes, I had tested it.
Comment 5 Adrien Plazas 2018-05-14 09:38:47 UTC 
FYI I am going to merge Virtual Boy support in Games soonish. :)
Comment 6 Victor Toso 2018-05-28 06:35:35 UTC 
This was pushed upstream as 2f119e1272394afba3634ab5bdbd3b9991571c35

From now on, please use MR at gitlab.gnome.org ;)

Cheers,