GNOME Bugzilla – Bug 795938
css.lang: Consistency fixes
Last modified: 2018-05-09 11:03:02 UTC
* At-rules (e.g. @media) at the beginning of a line are highlighted, but at-rules following other rules on the same line are not * Top-level strings are highlighted, but strings inside style blocks are not * The equals sign in an attribute selector like [title="Foobar"] is highlighted, but other attribute selector operators (e.g. [class~="required"]) are not * The general sibling selector (p ~ ul) is highlighted differently than other combinators (div + div, ul > li) Will attach a patch to address these shortly.
Created attachment 371809 [details] [review] css.lang: Consistency fixes * Remove requirement that at-rules start at the beginning of a line * Add string highlighting to style-block and function contexts * Rename attribute-value-delimiter context to attribute-selector-delimiter, to clarify purpose * Rework operators context and rename to attribute-selector-operators * Add general sibling selector (~) to selector-grammar context
I have a conflict in git when trying to apply the above patch. Also, it takes more time for me if you open lots of bugs. I prefer if you open just one bug with "css.lang: various improvements" and attach all the patches there in the good order. Hopefully GtkSourceView will be migrated to GitLab soon.
I have rebased on current master and will upload a new patch. Also, will gather future patches in one bug. Thanks for all your help in merging these :-)
Created attachment 371832 [details] [review] css.lang: Consistency fixes * Remove requirement that at-rules start at the beginning of a line * Add string highlighting to style-block and function contexts * Rename attribute-value-delimiter context to attribute-selector-delimiter, to clarify purpose * Rework operators context and rename to attribute-selector-operators * Add general sibling selector (~) to selector-grammar context
Thanks, pushed as commit b3e895d47a34d8d3dea10748345d248084e68c1e.