After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 795937 - uridecodebin3: Fix GList leak
uridecodebin3: Fix GList leak
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal normal
: 1.14.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-05-08 15:56 UTC by Seungha Yang
Modified: 2018-05-09 06:34 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
uridecodebin3: Fix GList leak (810 bytes, patch)
2018-05-08 15:57 UTC, Seungha Yang 		none Details | Review
uridecodebin3: Fix GList leak (867 bytes, patch)
2018-05-09 01:43 UTC, Seungha Yang 		committed Details | Review

Description Seungha Yang 2018-05-08 15:56:33 UTC 
Fix GList leak detected by valgrind
Comment 1 Seungha Yang 2018-05-08 15:57:25 UTC 
Created attachment 371807 [details] [review]
uridecodebin3: Fix GList leak
Comment 2 Tim-Philipp Müller 2018-05-08 16:23:51 UTC 
Comment on attachment 371807 [details] [review]
uridecodebin3: Fix GList leak

Thanks for the patch.

I think the

  g_list_remove_link(.., tmp)

earlier in the code should perhaps be

  g_list_delete_link(.., tmp)

instead.
Comment 3 Seungha Yang 2018-05-09 01:43:01 UTC 
Created attachment 371826 [details] [review]
uridecodebin3: Fix GList leak

Use g_list_delete_link instead of g_list_remove_link
Comment 4 Tim-Philipp Müller 2018-05-09 06:34:04 UTC 
commit 7e724bddf393549760fa5859d6a2646c23b6da03 (HEAD -> master)
Author: Seungha Yang <seungha.yang@navercorp.com>
Date:   Wed May 9 10:39:23 2018 +0900

    uridecodebin3: Fix GList leak
    
    https://bugzilla.gnome.org/show_bug.cgi?id=795937