After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 795874 - omx: always consider component in 'invalid' state when an error occured
omx: always consider component in 'invalid' state when an error occured
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-omx
unspecified
Other Linux
: Normal normal
: 1.15.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-05-07 10:02 UTC by Guillaume Desmottes
Modified: 2018-06-08 07:37 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
omx: always consider component in 'invalid' state when an error occured (1.48 KB, patch)
2018-05-07 10:02 UTC, Guillaume Desmottes 		committed Details | Review

Description Guillaume Desmottes 2018-05-07 10:02:26 UTC 
.
Comment 1 Guillaume Desmottes 2018-05-07 10:02:48 UTC 
Created attachment 371768 [details] [review]
omx: always consider component in 'invalid' state when an error occured

gst_omx_component_get_state() used to early return if there was no
pending state change. So if the component raised an error it wasn't
considered in the invalid state until the next requested state change.

Fix this by checking first if we received an error.
Comment 2 Nicolas Dufresne (ndufresne) 2018-06-07 18:57:12 UTC 
Review of attachment 371768 [details] [review]:

Go ahead.
Comment 3 Guillaume Desmottes 2018-06-08 07:37:24 UTC 
Attachment 371768 [details] pushed as 3498f81 - omx: always consider component in 'invalid' state when an error occured