Bug 795861 – Segfault on Undo

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 795861 - Segfault on Undo


Summary:	Segfault on Undo


Status:	RESOLVED FIXED

Product:	Gnumeric
Classification:	Applications
Component:	Main System
Version:	unspecified
Hardware:	Other Linux

Importance:	Normal normal
Target Milestone:	---
Assigned To:	Jody Goldberg
QA Contact:	Jody Goldberg

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2018-05-06 19:10 UTC by Andreas J. Guelzow
Modified:	2018-05-06 22:23 UTC

See Also:
GNOME target:	---
GNOME version:	---

Description Andreas J. Guelzow 2018-05-06 19:10:20 UTC

new workbook
enter 1 in A1 and 2 in B1
select A3:A4
in this selected range enter the array function =TRANSPOSE(A1:B1)
Undo
boom....

Comment 1 Andreas J. Guelzow 2018-05-06 19:14:32 UTC

Thread 1 "gnumeric-1.12.4" received signal SIGSEGV, Segmentation fault.
0x00007ffff78f933b in cb_clear_variable_width_content (
    iter=iter@entry=0x7fffffffd3d0, user=user@entry=0x0) at colrow.c:500
500			iter->ri->needs_respan = TRUE;
(gdb) bt

+ Trace 238603

#0 cb_clear_variable_width_content
at colrow.c line 500
#1 sheet_foreach_cell_in_region
at sheet.c line 4189
#2 colrow_restore_state_group
at colrow.c line 775
#3 go_undo_group_undo
at utils/go-undo.c line 152
#4 cmd_generic_undo
at commands.c line 6527
#5 command_undo
at commands.c line 395

Comment 2 Morten Welinder 2018-05-06 19:45:55 UTC

Definitely.  iter->ri NULL which is strange for an existing cell.  It's
easily worked around, but why does it happen and why now?

Comment 3 Morten Welinder 2018-05-06 20:24:35 UTC

58c0499f19e29e9396825f1834fb1ac5173f605c is the first bad commit
commit 58c0499f19e29e9396825f1834fb1ac5173f605c
Author: Morten Welinder <terra@gnome.org>
Date:   Mon Apr 23 22:54:32 2018 -0400

    Paste: also paste widths of full columns pasted.
    
    Work in progress.  Undo doesn't work yet.

:040000 040000 c0710379800edd5459a1e6240e8deb7b54da8e20 2d4c04cd88c455a5bdb99d7926c68d559d6c38df M	src

Comment 4 Morten Welinder 2018-05-06 22:23:55 UTC

Fixed, but there might be similar issues.

This problem has been fixed in our software repository. The fix will go into the next software release. Once that release is available, you may want to check for a software upgrade provided by your Linux distribution.