Created attachment 371753 [details] [review]
patch

Created attachment 371755 [details] [review]
same patch without typo

Not that this patch really makes it any worse, but there's a worrying lack of locking in uridecodebin3 around bits of data that are accessed and modified from multiple threads.

(In reply to Jan Schmidt from comment #3)
> Not that this patch really makes it any worse, but there's a worrying lack
> of locking in uridecodebin3 around bits of data that are accessed and
> modified from multiple threads.

I agree. Do yo want me to start fixing this with this patch or can the existing patch be reviewed and locking added later on?

Review of attachment 371755 [details] [review]:

::: gst/playback/gsturidecodebin3.c
@@ -854,1 +876,4 @@
-      g_value_set_string (value, dec->suburi);
+      if (dec->current && dec->current->main_item) {
+        g_value_set_string (value, dec->current->main_item->uri);
+      } else {
+        g_value_set_string (value, "");

Can you just use `dec->uri` here?

@@ -1015,1 +1038,2 @@
   dec->play_items = g_list_append (dec->play_items, item);
+  dec->current = dec->play_items->data;

That was never set at all right? I have the impression something is missing in term of ownership here.

-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/issues/451.