After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 795840 - [PATCH] Add dynamic password infrastructure
[PATCH] Add dynamic password infrastructure
Status: RESOLVED OBSOLETE
Product: grilo
Classification: Other
Component: core
0.3.x
Other Linux
: Normal enhancement
: ---
Assigned To: grilo-maint
grilo-maint
Depends on:
Blocks:
 
 
Reported: 2018-05-05 15:59 UTC by W. Michael Petullo
Modified: 2018-09-24 09:57 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
core: add dynamic password infrastructure (8.24 KB, patch)
2018-05-05 15:59 UTC, W. Michael Petullo
none Details | Review
dmap: add support for password-protected DAAP shares (3.51 KB, patch)
2018-05-05 16:00 UTC, W. Michael Petullo
none Details | Review
core: add dynamic password infrastructure (8.24 KB, patch)
2018-05-05 16:10 UTC, W. Michael Petullo
none Details | Review
dmap: add support for password-protected DPAP shares (7.70 KB, patch)
2018-05-09 02:03 UTC, W. Michael Petullo
none Details | Review

Description W. Michael Petullo 2018-05-05 15:59:51 UTC
Created attachment 371722 [details] [review]
core: add dynamic password infrastructure

Some media sources (e.g., DAAP) support notifying a client that a password is required at connection time. Since such sources are commonly detected with protocols like DNS-SD, Grilo needs a mechanism to support handling such password requests.
    
This work adds a new "grl_source_notify_authenticate" function which a plugin can call when a password is needed. The function, in turn, emits an "authenticate" signal which the application should respond to by obtaining a password. The application then provides the password back to the plugin by calling the new "grl_daap_source_continue_with_password" function.
Comment 1 W. Michael Petullo 2018-05-05 16:00:51 UTC
Created attachment 371723 [details] [review]
dmap: add support for password-protected DAAP shares
Comment 2 W. Michael Petullo 2018-05-05 16:10:20 UTC
Created attachment 371725 [details] [review]
core: add dynamic password infrastructure
Comment 3 W. Michael Petullo 2018-05-09 02:03:50 UTC
Created attachment 371827 [details] [review]
dmap: add support for password-protected DPAP shares
Comment 4 Victor Toso 2018-05-28 06:29:22 UTC
Hi, thank you for your patches and sorry for taking some time to reply here.

The idea is okay but would you mind submitting a MR in https://gitlab.gnome.org/GNOME/grilo and grilo-plugins?
Comment 5 W. Michael Petullo 2018-05-28 17:46:34 UTC
See the following two merge requests:

https://gitlab.gnome.org/GNOME/grilo/merge_requests/3
https://gitlab.gnome.org/GNOME/grilo-plugins/merge_requests/1
Comment 6 GNOME Infrastructure Team 2018-09-24 09:57:35 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/grilo/issues/132.