After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 795750 - Missing features in case a feature moves to another filename
Missing features in case a feature moves to another filename
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
1.14.0
Other Linux
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-05-02 11:26 UTC by Christoph Reiter (lazka)
Modified: 2018-11-03 12:46 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
gstelementfactory: Fix missing features in case a feature moves to another filename (2.03 KB, patch)
2018-05-02 11:26 UTC, Christoph Reiter (lazka)
none Details | Review

Description Christoph Reiter (lazka) 2018-05-02 11:26:36 UTC
Created attachment 371609 [details] [review]
gstelementfactory: Fix missing features in case a feature  moves to another filename

In case a plugin filename was renamed with the plugin being in the registry cache
the features where not loaded after the rename:

1) Cache of old/gone filename was loaded, features added
2) New filename was loaded, features where not added because
   they were already found in the registry.
3) In the end stale cache entries for files which are no longer there
   are removed, including the wanted features.
4) The cache gets updated without the features.

Fix this by also checking at (2) that the found feature is from the loaded plugin
and not from some stale cache entry.

This affected directsoundsink where libgstdirectsoundsink.dll was renamed
to libgstdirectsound.dll, losing the directsoundsink element in the process.
Comment 1 Christoph Reiter (lazka) 2018-05-06 09:55:17 UTC
ML discussion for the same problem: https://lists.freedesktop.org/archives/gstreamer-devel/2018-April/067536.html
Comment 2 GStreamer system administrator 2018-11-03 12:46:13 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gstreamer/issues/290.