After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 795741 - harness: improve _wait_for_clock_id_waits performance
harness: improve _wait_for_clock_id_waits performance
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other All
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-05-02 08:18 UTC by Håvard Graff (hgr)
Modified: 2018-11-03 12:46 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
harness: improve _wait_for_clock_id_waits performance (5.02 KB, patch)
2018-05-02 08:18 UTC, Håvard Graff (hgr) 		none Details | Review

Description Håvard Graff (hgr) 2018-05-02 08:18:55 UTC 
Created attachment 371596 [details] [review]
harness: improve _wait_for_clock_id_waits performance

By moving the functionality down to the testclock, the implementation
no longer needs to poll the waits, but rather wait properly for
them to be added.

The performance-hit here would be that by polling the test-clock
regularly, you would create contention on the testclock-lock, making code
using the testclock (gst_clock_id_wait) fighting for the lock.
Comment 1 Håvard Graff (hgr) 2018-09-17 11:33:10 UTC 
ping?
Comment 2 Tim-Philipp Müller 2018-09-17 11:52:20 UTC 
Looks fine to me.

Since marker should be 'Since: 1.16' but I can fix that up.

We seem to be doing a few g_list_length() here, which I guess isn't a problem for small lists, but feels a bit suboptimal. I guess it's an implementation detail and we can fix it up later if it becomes a problem
Comment 3 GStreamer system administrator 2018-11-03 12:46:00 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gstreamer/issues/288.