After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 795730 - package-config generation bug, wrong format used in meson.build.
package-config generation bug, wrong format used in meson.build.
Status: RESOLVED OBSOLETE
Product: libgit2-glib
Classification: Core
Component: General
git master
Other Linux
: Normal normal
: ---
Assigned To: gitg-maint
gitg-maint
Depends on:
Blocks:
 
 
Reported: 2018-05-01 21:34 UTC by Roy Buitenhuis
Modified: 2019-02-22 03:52 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
The requires field expects a list of strings. (700 bytes, patch)
2018-05-01 21:34 UTC, Roy Buitenhuis 		none Details | Review
changes to last patch (664 bytes, patch)
2018-05-02 08:57 UTC, Roy Buitenhuis 		none Details | Review

Description Roy Buitenhuis 2018-05-01 21:34:59 UTC 
Created attachment 371587 [details] [review]
The requires field expects a list of strings.

This caused an error as the pc file looks like this, it misses the spaces after the first dependency:

prefix=/home/roy/jhbuild/install
libdir=${prefix}/lib
includedir=${prefix}/include

exec_prefix=${prefix}

Name: libgit2-glib
Description: libgit2-glib, a a glib wrapper library around the libgit2 git access library.
Version: 0.26.4
Requires: libgit2 >= 0.25.0,glib-2.0>=2.44.0,gobject-2.0>=2.44.0,gio-2.0>=2.44.0
Libs: -L${libdir} -lgit2-glib-1.0
Cflags: -I${includedir}/libgit2-glib-1.0 -DGIT_SSH=1

This patch fixes it.
Comment 1 André Klapper 2018-05-02 08:29:28 UTC 
Thanks!
Why is this marked as a security bug?
Comment 2 Roy Buitenhuis 2018-05-02 08:46:11 UTC 
I don't know, did I mark that somewhere?
Comment 3 Roy Buitenhuis 2018-05-02 08:57:15 UTC 
Created attachment 371601 [details] [review]
changes to last patch

Don't really need to do the string.format anymore, this looks better and works fine.
Comment 4 GNOME Infrastructure Team 2018-05-22 13:29:50 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gitg/issues/119.