After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 795705 - meson post-install.sh script fails to run if bash isn't at /usr/bin/bash
meson post-install.sh script fails to run if bash isn't at /usr/bin/bash
Status: RESOLVED FIXED
Product: gdk-pixbuf
Classification: Platform
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gdk-pixbuf-maint
gdk-pixbuf-maint
Depends on:
Blocks:
 
 
Reported: 2018-04-30 21:41 UTC by Brendan L
Modified: 2018-05-01 12:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Possible fix for post-install script (544 bytes, patch)
2018-04-30 21:41 UTC, Brendan L 		needs-work Details | Review
A patch to solve build problems in some systems. (521 bytes, patch)
2018-04-30 22:27 UTC, Roy Buitenhuis 		none Details | Review
Change shell to /bin/sh (550 bytes, patch)
2018-04-30 22:58 UTC, Brendan L 		committed Details | Review

Description Brendan L 2018-04-30 21:41:39 UTC 
Created attachment 371562 [details] [review]
Possible fix for post-install script

My bash in is /bin so the post-install script fails for me.  I've attached a possible fix, but I don't know if it's the best way.  It works for me though.
Comment 1 Emmanuele Bassi (:ebassi) 2018-04-30 22:02:24 UTC 
Review of attachment 371562 [details] [review]:

Thanks for catching this.

::: build-aux/post-install.sh
@@ +1,1 @@
+#!/usr/bin/env bash

It's probably better to just use `#!/bin/sh`; I was way too conservative, but I'm not using any bashisms.
Comment 2 Roy Buitenhuis 2018-04-30 22:27:40 UTC 
Created attachment 371563 [details] [review]
A patch to solve build problems in some systems.

This was the commit I made and created a pull request for on Github, but I deleted the repository.
Comment 3 Brendan L 2018-04-30 22:58:02 UTC 
Created attachment 371565 [details] [review]
Change shell to /bin/sh

I added the change to /bin/sh option has well.
Comment 4 Emmanuele Bassi (:ebassi) 2018-05-01 10:46:00 UTC 
Review of attachment 371565 [details] [review]:

Thanks, this looks good.
Comment 5 Emmanuele Bassi (:ebassi) 2018-05-01 12:28:27 UTC 
Attachment 371565 [details] pushed to master as commit d2098ff6.