After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 795627 - sqlite3.vapi missing some const values for sqlite3_open_v2()
sqlite3.vapi missing some const values for sqlite3_open_v2()
Status: RESOLVED FIXED
Product: vala
Classification: Core
Component: Bindings: Extra
unspecified
Other Linux
: Normal normal
: 0.42
Assigned To: Vala maintainers
Vala maintainers
Depends on:
Blocks:
 
 
Reported: 2018-04-28 10:51 UTC by Michael Gratton
Modified: 2018-04-30 07:35 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add additional SQLite 3 sqlite3_open_v2 const values. (1.13 KB, patch)
2018-04-28 10:51 UTC, Michael Gratton
committed Details | Review
sqlite3: Add Sqlite.OpenFlags enum for flags of Database.open_v2() (1.46 KB, patch)
2018-04-30 07:29 UTC, Rico Tzschichholz
none Details | Review

Description Michael Gratton 2018-04-28 10:51:19 UTC
Created attachment 371491 [details] [review]
Add additional SQLite 3 sqlite3_open_v2 const values.

sqlite3.vapi is missing some consts that SQLite ships with these days. I'd like to use OPEN_URI for Geary's unit tests.

Patch adds all currently missing values per https://www.sqlite.org/c3ref/c_open_autoproxy.html
Comment 1 Rico Tzschichholz 2018-04-29 11:39:20 UTC
I have pushed this, so this can be easily backported.

Given the amount of those symbols it would make sense to make them an Enum for easier accessing?
Comment 2 Michael Gratton 2018-04-30 04:57:34 UTC
Probably, as a flag enum yeah, but would using an Enum break compat with the existing Sqlite.Database.open_v2() method signature?
Comment 3 Rico Tzschichholz 2018-04-30 07:29:14 UTC
Created attachment 371532 [details] [review]
sqlite3: Add Sqlite.OpenFlags enum for flags of Database.open_v2()
Comment 4 Rico Tzschichholz 2018-04-30 07:35:39 UTC
It preserves backwards compat and make type-inferenced usage possible.

Sqlite.Database.open_v2 ("/tmp/test", out db, READWRITE | CREATE);