After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 795578 - Handle x-gvfs- options not only for fstab entries
Handle x-gvfs- options not only for fstab entries
Status: RESOLVED FIXED
Product: gvfs
Classification: Core
Component: udisks2 volume monitor
unspecified
Other All
: Normal normal
: ---
Assigned To: gvfs-maint
gvfs-maint
Depends on: 668132
Blocks:
 
 
Reported: 2018-04-26 12:28 UTC by Ondrej Holy
Modified: 2018-05-23 08:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
udisks2: Handle x-gvfs- options not only for fstab entries (2.71 KB, patch)
2018-04-26 12:28 UTC, Ondrej Holy 		none Details | Review
udisks2: Handle x-gvfs- options not only for fstab entries (2.71 KB, patch)
2018-05-23 08:39 UTC, Ondrej Holy 		committed Details | Review

Description Ondrej Holy 2018-04-26 12:28:49 UTC 
GVfsUDisks2VolumeMonitor handles x-gvfs-hide/x-gvfs-show mount options
used to overwrite our heuristics whether the mount should be shown, or
hidden. Unfortunately, it works currently only for mounts with
corresponding fstab entries, because the options are read over
g_unix_mount_point_get_options. Let's use the newly introduced
g_unix_mount_get_options to allow reading of the options for all sort
of mounts (e.g. created over pam_mount, or manually mounted).

GLib dependency has to be bumped accordingly before push...
Comment 1 Ondrej Holy 2018-04-26 12:28:55 UTC 
Created attachment 371429 [details] [review]
udisks2: Handle x-gvfs- options not only for fstab entries
Comment 2 Ondrej Holy 2018-05-23 08:39:09 UTC 
Created attachment 372355 [details] [review]
udisks2: Handle x-gvfs- options not only for fstab entries

GVfsUDisks2VolumeMonitor handles x-gvfs-hide/x-gvfs-show mount options
used to overwrite our heuristics whether the mount should be shown, or
hidden. Unfortunately, it works currently only for mounts with
corresponding fstab entries, because the options are read over
g_unix_mount_point_get_options. Let's use the newly introduced
g_unix_mount_get_options to allow reading of the options for all sort
of mounts (e.g. created over pam_mount, or manually mounted).

Update GLib dependency accordingly.
Comment 3 Ondrej Holy 2018-05-23 08:42:42 UTC 
Attachment 372355 [details] pushed as 959db3e - udisks2: Handle x-gvfs- options not only for fstab entries