After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 795501 - SRT Passphrase not working
SRT Passphrase not working
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
1.14.0
Other Linux
: Normal major
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on: 792189
Blocks:
 
 
Reported: 2018-04-24 08:55 UTC by Marcus
Modified: 2018-11-03 14:21 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Marcus 2018-04-24 08:55:54 UTC
As discussed on the mailing list here: https://lists.freedesktop.org/archives/gstreamer-devel/2018-April/067657.html

It appears that the passphrase parameter for the SRT plugins are not functioning correctly.

Copied from my original post in the mailing list:

We've been playing with the new SRT plugins as part of gst-plugins-bad and
all seems well apart from a couple of features.

Using it like so on the client (sender):
... srtclientsink passphrase=eb55dec3c22f4e0879baadfe2fd50151
uri=srt://10.10.10.10:6000...

And on the server (listener):
... srtserversrc passphrase=eb55dec3c22f4e0879baadfe2fd50151
uri=srt://:6000...

The first one being the passphrase parameter. At first, I assumed it was
working fine and the stream was encrypted, but after accidentally setting
the wrong password on the srtserversrc, to my surprise, the stream sill
worked. After some investigation, it seems that it works with or without a
passphrase, even if the passphrase is set on the srtclientsink.

I've tried everything it feels like to try and get this to work, this
includes:
- Setting the key-length to 16 even though that's the default
- Trying the other key-lengths
- Wrapping the passphrase in "quotes"
- Using different passphrases with different lengths
- Using only integers for the passphrase instead
... all on both sides of the pipeline.

However, it always seems that the stream is being sent unencrypted. Even
with debug level set on both plugins, there are no complaints or logs to
suggest anything is wrong.

I've scoured the web for examples but none can be found where the
passphrase is being used. So I'm now thinking there is either a bug or we
are doing something incorrectly here.

If we are doing something wrong, then I would have thought that something
should at least error or give a warning, rather than allow the stream to go
through unencrypted...
Comment 1 Olivier Crête 2018-04-24 14:57:02 UTC
I can reproduce this problem with SRT 1.2, but when I upgraded to 1.3, the problem went away, so I think this is a bug in libsrt.
Comment 2 Tim-Philipp Müller 2018-04-24 15:08:58 UTC
Sounds like we should bump the req then?

Unintentionally sending unencrypted data seems quite bad.
Comment 3 Nicolas Dufresne (ndufresne) 2018-04-24 17:23:14 UTC
Ok.
Comment 4 GStreamer system administrator 2018-11-03 14:21:59 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/issues/694.