After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 795500 - Fails to build with vala git master
Fails to build with vala git master
Status: RESOLVED FIXED
Product: gitg
Classification: Applications
Component: gitg
git master
Other Linux
: Normal normal
: ---
Assigned To: gitg-maint
gitg-maint
Depends on:
Blocks:
 
 
Reported: 2018-04-24 08:13 UTC by Rico Tzschichholz
Modified: 2018-04-25 06:52 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Drop default value of non-automatic property for newer vala (4.00 KB, patch)
2018-04-24 08:14 UTC, Rico Tzschichholz
none Details | Review
Drop default value of non-automatic property for newer vala (6.04 KB, patch)
2018-04-24 15:31 UTC, Rico Tzschichholz
committed Details | Review

Comment 1 Rico Tzschichholz 2018-04-24 08:14:01 UTC
Created attachment 371314 [details] [review]
Drop default value of non-automatic property for newer vala
Comment 2 Ignacio Casal Quinteiro (nacho) 2018-04-24 08:15:29 UTC
Review of attachment 371314 [details] [review]:

OK
Comment 3 Rico Tzschichholz 2018-04-24 08:20:21 UTC
@nacho Please look for possible side-effects of this change.
Comment 4 Rico Tzschichholz 2018-04-24 15:31:40 UTC
Created attachment 371326 [details] [review]
Drop default value of non-automatic property for newer vala
Comment 5 Rico Tzschichholz 2018-04-25 06:52:33 UTC
Attachment 371326 [details] pushed as c2a4e98 - Drop default value of non-automatic property for newer vala