After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 795464 - encodebin: Also lock input caps when dynamic output is disabled
encodebin: Also lock input caps when dynamic output is disabled
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
unspecified
Other All
: Normal normal
: 1.14.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-04-22 13:55 UTC by Thibault Saunier
Modified: 2018-05-02 08:39 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
encodebin: Also lock input caps when dynamic output is disabled (3.98 KB, patch)
2018-04-22 13:55 UTC, Thibault Saunier
committed Details | Review

Description Thibault Saunier 2018-04-22 13:55:39 UTC
.
Comment 1 Thibault Saunier 2018-04-22 13:55:44 UTC
Created attachment 371231 [details] [review]
encodebin: Also lock input caps when dynamic output is disabled

With the way caps negotiation work in encoders, the only way to ensure
that no downstream renegotiation is done in the encoder is to also lock
upstream caps. Anyway with the current behavior upstream of encoders
*require* to handle any file format so locking upstream format should
be safe.
Comment 2 Thibault Saunier 2018-05-01 19:16:58 UTC
Attachment 371231 [details] pushed as 9ce8cf8 - encodebin: Also lock input caps when dynamic output is disabled
Comment 3 Thibault Saunier 2018-05-02 08:39:25 UTC
Backported on 1.14.1