After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 795436 - video: Safe guard info->finfo when mapping a frame
video: Safe guard info->finfo when mapping a frame
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
unspecified
Other All
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-04-21 12:55 UTC by Thibault Saunier
Modified: 2018-04-21 23:48 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
video: Safe guard info->finfo when mapping a frame (941 bytes, patch)
2018-04-21 12:56 UTC, Thibault Saunier 		committed Details | Review

Description Thibault Saunier 2018-04-21 12:55:59 UTC 
Not sure how that slept through but that case is possible and leads
to segfaults in any code path of the function right now.
Comment 1 Thibault Saunier 2018-04-21 12:56:04 UTC 
Created attachment 371214 [details] [review]
video: Safe guard info->finfo when mapping a frame
Comment 2 Nicolas Dufresne (ndufresne) 2018-04-21 17:24:26 UTC 
I think your patch is correct in catching dev error. It would mean one is passing an uninitialized GstVideoInfo.
Comment 3 Thibault Saunier 2018-04-21 23:48:23 UTC 
Attachment 371214 [details] pushed as b63fc21 - video: Safe guard info->finfo when mapping a frame