After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 795429 - glib-genmarshal shows redundant "time" warning message against combination with --header and --body option
glib-genmarshal shows redundant "time" warning message against combination wi...
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gobject
unspecified
Other All
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2018-04-21 07:50 UTC by Kentaro Hayashi
Modified: 2018-04-23 15:26 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Path to fix redundant time from glib-genmarshal (663 bytes, patch)
2018-04-21 07:50 UTC, Kentaro Hayashi
none Details | Review
Patch to fix redundant time from glib-genmarshal (1.40 KB, patch)
2018-04-21 08:17 UTC, Kentaro Hayashi
committed Details | Review

Description Kentaro Hayashi 2018-04-21 07:50:21 UTC
Created attachment 371199 [details] [review]
Path to fix redundant time from glib-genmarshal

glib-genmarshal shows redundant "time" warning message against combination with --header and --body option.

Here is the actual message when --header and --body was specified at the same time.


glib-genmarshal ../gcutter/gcut-marshalers.list --header --body --prefix=_gcut_marshal > gcut-marshalers.c
WARNING: Using --header and --body at the same time time is deprecated; use --body --prototypes instead

Actual:

  WARNING: Using --header and --body at the same time time is deprecated; use --body --prototypes instead

Expected:

WARNING: Using --header and --body at the same time is deprecated; use --body --prototypes instead
Comment 1 Daniel Boles 2018-04-21 07:58:37 UTC
Thanks, but we'd need a Git-formatted patch to preserve attribution to you (without undue hassle).
Comment 2 Kentaro Hayashi 2018-04-21 08:17:00 UTC
Created attachment 371200 [details] [review]
Patch to fix redundant time from glib-genmarshal

I've attached the patch.
Comment 3 Philip Withnall 2018-04-23 15:16:08 UTC
Review of attachment 371200 [details] [review]:

Great, thanks.
Comment 4 Philip Withnall 2018-04-23 15:25:18 UTC
Pushed to master, thanks.
Comment 5 Philip Withnall 2018-04-23 15:26:52 UTC
And pushed to glib-2-56 too:

807648663 (HEAD -> master, origin/master, origin/HEAD) gobject: Fix redundant warning message in glib-genmarshal
926a5c5e5 (HEAD -> glib-2-56, origin/glib-2-56) gobject: Fix redundant warning message in glib-genmarshal