After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 795428 - dssim: Add a dssim-error-threshold property
dssim: Add a dssim-error-threshold property
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
unspecified
Other All
: Normal normal
: 1.15.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-04-21 00:55 UTC by Thibault Saunier
Modified: 2018-04-21 01:35 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
dssim: Add a dssim-error-threshold property (3.79 KB, patch)
2018-04-21 00:55 UTC, Thibault Saunier
none Details | Review
dssim: Add a dssim-error-threshold property (3.78 KB, patch)
2018-04-21 01:17 UTC, Thibault Saunier
committed Details | Review

Description Thibault Saunier 2018-04-21 00:55:24 UTC
.
Comment 1 Thibault Saunier 2018-04-21 00:55:31 UTC
Created attachment 371190 [details] [review]
dssim: Add a dssim-error-threshold property

If that threshold is reached, `iqa` will emit an ERROR message on the
bus, stopping any processing.

This way we can do a simpler comparison with gst-validate and the
process will error out if the specified threshold is reached.
Comment 2 Thibault Saunier 2018-04-21 01:17:12 UTC
Created attachment 371191 [details] [review]
dssim: Add a dssim-error-threshold property

If that threshold is reached, `iqa` will emit an ERROR message on the
bus, stopping any processing.

This way we can do a simpler comparison with gst-validate and the
process will error out if the specified threshold is reached.
Comment 3 Mathieu Duponchelle 2018-04-21 01:19:41 UTC
Review of attachment 371191 [details] [review]:

Looks good to me apart from that, useful addition :)

::: ext/iqa/iqa.c
@@ -305,2 +333,3 @@
       g_value_set_boolean (value, self->do_dssim);
       break;
+    case PROP_SSIM_ERROR_THRESHOLD:

might as well lock in set_prop too :)
Comment 4 Thibault Saunier 2018-04-21 01:34:43 UTC
Attachment 371191 [details] pushed as cbb4bdb - dssim: Add a dssim-error-threshold property