After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 795426 - theoraenc: Make sure sinkpad caps are never renegotiated
theoraenc: Make sure sinkpad caps are never renegotiated
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
unspecified
Other All
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-04-20 23:38 UTC by Thibault Saunier
Modified: 2018-11-03 12:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
theoraenc: Make sure sinkpad caps are never renegotiated (1.56 KB, patch)
2018-04-20 23:39 UTC, Thibault Saunier 		none Details | Review

Description Thibault Saunier 2018-04-20 23:38:59 UTC 
See commit message.
Comment 1 Thibault Saunier 2018-04-20 23:39:05 UTC 
Created attachment 371189 [details] [review]
theoraenc: Make sure sinkpad caps are never renegotiated

This is not supported and we should NNE if upstream is not able to
handle that restriction.

Currently theoraenc silently accepts it and outputs pure garbage.
Comment 2 Sebastian Dröge (slomo) 2018-04-21 10:39:14 UTC 
This should be fine if it comes together with a caps change which contains the new stream headers. Only none of the muxers apart from rtpgstpay/gdppay would be able to handle this right now I guess.
Comment 3 Thibault Saunier 2018-04-21 11:53:28 UTC 
(In reply to Sebastian Dröge (slomo) from comment #2)
> This should be fine if it comes together with a caps change which contains
> the new stream headers. Only none of the muxers apart from rtpgstpay/gdppay
> would be able to handle this right now I guess.

So shouldn't we just disallow it for now, otherwise I can take the same approach as in jpegenc: https://bugzilla.gnome.org/show_bug.cgi?id=795415 where I allow renegotiation when downstream lets us do.

Seeing how it behaves right now I would just disallow renegotiation all together for theoraenc tbh.
Comment 4 GStreamer system administrator 2018-11-03 12:05:19 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/issues/437.