After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 795361 - metrolyrics: Add debug helper to the tests
metrolyrics: Add debug helper to the tests
Status: RESOLVED FIXED
Product: grilo
Classification: Other
Component: lua
unspecified
Other All
: Normal normal
: ---
Assigned To: grilo-maint
grilo-maint
Depends on:
Blocks:
 
 
Reported: 2018-04-18 16:10 UTC by Bastien Nocera
Modified: 2018-04-24 13:15 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
metrolyrics: Add debug helper to the tests (1.56 KB, patch)
2018-04-18 16:10 UTC, Bastien Nocera
none Details | Review
tests: Disable metrolyrics test while it's broken (729 bytes, patch)
2018-04-24 13:14 UTC, Bastien Nocera
none Details | Review

Description Bastien Nocera 2018-04-18 16:10:29 UTC
.
Comment 1 Bastien Nocera 2018-04-18 16:10:34 UTC
Created attachment 371107 [details] [review]
metrolyrics: Add debug helper to the tests

Save the "computed" lyrics to a temporary file on disk, so as to avoid
having to guess how to have it downloaded and processed.
Comment 2 Bastien Nocera 2018-04-18 16:11:07 UTC
Then somebody would need to make it work as well :/
Comment 3 Victor Toso 2018-04-18 18:17:28 UTC
IMHO we should remove it. A html parsing source is too troublesome to keep working plus I don't know any app that is using it.

I have to give it a full read but muxixmatch sounds better replacement ~
https://about.musixmatch.com/apiterms/
Comment 4 Bastien Nocera 2018-04-24 13:14:27 UTC
Created attachment 371323 [details] [review]
tests: Disable metrolyrics test while it's broken
Comment 5 Bastien Nocera 2018-04-24 13:15:28 UTC
commit 4130f1d7006d62b3115923971dddce36eaa08848
Author: Bastien Nocera <hadess@hadess.net>
Date:   Tue Apr 24 15:13:06 2018 +0200

    tests: Disable metrolyrics test while it's broken
    
    https://bugzilla.gnome.org/show_bug.cgi?id=795361

commit f0f14a4fdfdbf1d70b0b28a2a18119da5f8ab4fa
Author: Bastien Nocera <hadess@hadess.net>
Date:   Wed Apr 18 18:08:59 2018 +0200

    metrolyrics: Add debug helper to the tests
    
    Save the "computed" lyrics to a temporary file on disk, so as to avoid
    having to guess how to have it downloaded and processed.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=795361