After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 795358 - Untranslated list of encodings in preferences
Untranslated list of encodings in preferences
Status: RESOLVED FIXED
Product: gnome-terminal
Classification: Core
Component: Profiles
3.28.x
Other All
: Normal normal
: ---
Assigned To: GNOME Terminal Maintainers
GNOME Terminal Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-04-18 14:48 UTC by Piotr Drąg
Modified: 2018-04-18 20:07 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix (605 bytes, patch)
2018-04-18 19:20 UTC, Egmont Koblinger 		committed Details | Review

Description Piotr Drąg 2018-04-18 14:48:49 UTC 
The list of encodings in Preferences → Compatibility is in English. The list in the Terminal → Set Character Encoding menu is properly translated, though.

gnome-terminal-3.28.1-1.fc28.x86_64
Comment 1 Egmont Koblinger 2018-04-18 19:20:43 UTC 
Created attachment 371114 [details] [review]
Fix
Comment 2 Christian Persch 2018-04-18 19:46:22 UTC 
Comment on attachment 371114 [details] [review]
Fix

Thanks!
Comment 3 Egmont Koblinger 2018-04-18 19:50:49 UTC 
From https://wiki.gnome.org/TranslationProject/HandlingStringFreezes

What changes are not affected by the string freeze?
[...]
- Addition of a translateable message [...] that is absolutely identical to an existing message that is already marked for translation, and that has the same meaning and context. [...]
[...]
- Marking a message for translation that was previously not marked for translation by accident.

I take it as it's okay to cherry-pick to 0-52, correct?
Comment 4 Christian Persch 2018-04-18 19:58:49 UTC 
Correct :-)
Comment 5 Egmont Koblinger 2018-04-18 20:06:28 UTC 
s/0-52/3-28 :)

Submitted to master & 3-28. (Not even sure if older ones are affected...)