After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 795331 - Use correct desktop-entry name in notifications
Use correct desktop-entry name in notifications
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Plugins
3.28.x
Other Linux
: Normal normal
: ---
Assigned To: evolution-plugin-maintainers
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2018-04-17 14:10 UTC by Mathieu Bridon
Modified: 2018-04-19 15:41 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fix the app id in notifications (1008 bytes, patch)
2018-04-17 14:11 UTC, Mathieu Bridon
reviewed Details | Review

Description Mathieu Bridon 2018-04-17 14:10:57 UTC
In GNOME Control Center, I've disabled the Evolution notifications.

Yet, I still see the notification bubbles whenever I receive email.

That's because the Evolution app id is now "org.gnome.Evolution", but in the notification it calls itself "evolution".

As a result, GNOME Shell sees that it should filter out notifications from "org.gnome.Evolution", and lets the ones from "evolution" pass through.
Comment 1 Mathieu Bridon 2018-04-17 14:11:53 UTC
Created attachment 371049 [details] [review]
Fix the app id in notifications

Without this, GNOME Shell can't properly filter out the Evolution
notifications.
Comment 2 Mathieu Bridon 2018-04-17 14:17:32 UTC
I'm not sure whether the patch above is the right thing to do, as it hardcodes the string, whereas you might want to reuse a variable like the current `PACKAGE` one.

However I didn't find an existing variable with that value, so I figured I'd do a simple patch just to illustrate the problem and what would be needed.

I tested it, and now I don't get notifications from Evolution any more, as expected.

Once I enable notifications for Evolution in GNOME Control Center again, I get the popups back.
Comment 3 Milan Crha 2018-04-19 12:03:51 UTC
Thanks for a bug report and patch. You are right, there's no such variable for the desktop-entry-name. I didn't add it, because it won't help that much and because I do not expect the .desktop file being renamed "any time soon" (read as: again). I searched the code and found two other places where I missed the change of the .desktop file when working on it, thus I fixed them as well.

By the way, Edit->Plugins->Mail Notifications->Configuration tab, it's the place where you can turn off new mail notifications (or tweak them) in Evolution.

Created commit c2493a729c in evo master (3.29.2+)
Created commit e42a2551d8 in evo gnome-3-28 (3.28.2+)
Comment 4 Mathieu Bridon 2018-04-19 15:41:10 UTC
> By the way, Edit->Plugins->Mail Notifications->Configuration tab, it's the place where you can turn off new mail notifications (or tweak them) in Evolution.


I know, but since GNOME has a central place to configure notifications for all apps, I'd rather use that.

Thanks for fixing this though, I had a feeling there would be other instances to fix as well but didn't find them.

I'll wait for 3.28.2 to land in Fedora. :)