GNOME Bugzilla – Bug 795331
Use correct desktop-entry name in notifications
Last modified: 2018-04-19 15:41:10 UTC
In GNOME Control Center, I've disabled the Evolution notifications. Yet, I still see the notification bubbles whenever I receive email. That's because the Evolution app id is now "org.gnome.Evolution", but in the notification it calls itself "evolution". As a result, GNOME Shell sees that it should filter out notifications from "org.gnome.Evolution", and lets the ones from "evolution" pass through.
Created attachment 371049 [details] [review] Fix the app id in notifications Without this, GNOME Shell can't properly filter out the Evolution notifications.
I'm not sure whether the patch above is the right thing to do, as it hardcodes the string, whereas you might want to reuse a variable like the current `PACKAGE` one. However I didn't find an existing variable with that value, so I figured I'd do a simple patch just to illustrate the problem and what would be needed. I tested it, and now I don't get notifications from Evolution any more, as expected. Once I enable notifications for Evolution in GNOME Control Center again, I get the popups back.
Thanks for a bug report and patch. You are right, there's no such variable for the desktop-entry-name. I didn't add it, because it won't help that much and because I do not expect the .desktop file being renamed "any time soon" (read as: again). I searched the code and found two other places where I missed the change of the .desktop file when working on it, thus I fixed them as well. By the way, Edit->Plugins->Mail Notifications->Configuration tab, it's the place where you can turn off new mail notifications (or tweak them) in Evolution. Created commit c2493a729c in evo master (3.29.2+) Created commit e42a2551d8 in evo gnome-3-28 (3.28.2+)
> By the way, Edit->Plugins->Mail Notifications->Configuration tab, it's the place where you can turn off new mail notifications (or tweak them) in Evolution. I know, but since GNOME has a central place to configure notifications for all apps, I'd rather use that. Thanks for fixing this though, I had a feeling there would be other instances to fix as well but didn't find them. I'll wait for 3.28.2 to land in Fedora. :)