GNOME Bugzilla – Bug 795312
Drop support for old versions of libmtp < 1.1.12
Last modified: 2018-04-18 03:39:00 UTC
We've kept all of the conditionals we've accumulated over the years as we added support for new libmtp functionality. It's become a pretty long list of versions, and there's no reason to support all the ancient releases. So, let's drop the supported versions older than 1.1.12. The latest 1.1.15 release has only been out for a few weeks, so it's a bit step to require that yet. This will bring us down to just two versions.
Created attachment 371006 [details] [review] Remove conditionals for libmtp < 1.1.12
Review of attachment 371006 [details] [review]: Looks ok, thanks! ::: meson.build @@ +439,3 @@ + libmtp_dep = dependency('libmtp', version: '>= 1.1.12') + foreach version: ['1.1.15'] nitpick: Doesn't make much sense to have foreach here now, but if you expect we will use again soon, it is probably ok...
(In reply to Ondrej Holy from comment #2) > + libmtp_dep = dependency('libmtp', version: '>= 1.1.12') > + foreach version: ['1.1.15'] > > nitpick: Doesn't make much sense to have foreach here now, but if you expect > we will use again soon, it is probably ok... Yeah, I thought about it but I figured there's a good chance we'll introduce a new version check - and if not, then this will all just go away when we move to only supporting >= 1.1.15