After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 795290 - gstplayer: not be able to set_seek_accurate() in playing state after API changing.
gstplayer: not be able to set_seek_accurate() in playing state after API chan...
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
1.14.0
Other Linux
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-04-16 08:29 UTC by Lyon
Modified: 2018-11-03 14:21 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Lyon 2018-04-16 08:29:04 UTC
Hi Slomo,
  I was doing the upgrade of GST1.12 to GST1.14 recently. And I noticed that gstplayer API gst_player_config_set_seek_accurate() is changed from 
gst_player_config_set_seek_accurate (GstPlayer * self, gboolean accurate)  to 
gst_player_config_set_seek_accurate (GstStructure * config, gboolean accurate)
on GST1.14

So in GST1.14, if we need to set accurate seek flag, we need to _get_config(), and after set_accurate_seek(), then _set_config() back.
However, in _set_config(), it only allows config setting when app_state is STOPPED. 

But actually when we trying to seek to some point when playing, we prefer not stop playing first and then switch back to playing again, we just set_aacurate_seek flag and do seek.

in previous GST1.12,  we just need set_accurate_seek flag and then seek.

Do you have any suggestion for this issue?
Comment 1 Lyon 2018-04-16 08:45:48 UTC
Should we just use previous api, (we can just set the config flag via  * gstplayer )?
Comment 2 Sebastian Dröge (slomo) 2018-04-16 08:59:00 UTC
What's the use-case for sometimes doing accurate seeks and sometimes not in the same run?
Comment 3 Lyon 2018-04-16 09:07:25 UTC
in our command line app, we just let users choose seek mode each time before seek, fast seek or accurate seek.
When users choose fast seek mode, will set accurate seek mode to FALSE
otherwise will set accurate seek flag to TRUE, and then start seeking.

So user will choose this flag when pipeline is in playing state before seeking.
Comment 4 GStreamer system administrator 2018-11-03 14:21:29 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/issues/690.