After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 795278 - Spell GnuTLS properly in the about dialog
Spell GnuTLS properly in the about dialog
Status: RESOLVED FIXED
Product: vte
Classification: Core
Component: general
git master
Other Linux
: Normal minor
: ---
Assigned To: VTE Maintainers
VTE Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-04-15 15:53 UTC by Michael Catanzaro
Modified: 2018-05-21 18:40 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fix (2.00 KB, patch)
2018-04-15 20:15 UTC, Egmont Koblinger
none Details | Review

Description Michael Catanzaro 2018-04-15 15:53:16 UTC
This is super trivial, but I'm going to report it anyway. In its About dialog, GNOME Terminal says:

"Using VTE version 0.50.2 +GNUTLS"

Should be:

"Using VTE version 0.50.2 +GnuTLS"
Comment 1 Egmont Koblinger 2018-04-15 20:15:51 UTC
Created attachment 370968 [details] [review]
Fix

Thanks for the report! The attached patch fixes it at a couple of more places too.

(string change -> intended for master only, no 0-52 backport)
Comment 2 Christian Persch 2018-04-15 20:23:55 UTC
I've been copying how "systemctl --version" lists the features (+FOO -BAR), and that one uses "+GNUTLS" too.

(Not a strong opinion either way, but usually GNU is in all capitals...)
Comment 3 Egmont Koblinger 2018-04-15 20:28:58 UTC
> usually GNU is in all capitals

Usually :)

I've quickly checked the homepage and Wikipedia article of this particular project, and they seem to consistently spell as "GnuTLS".

I'm not against insisting on all uppercase (like systemctl does) in the version report, however, I'd still submit the remaining bits of the patch then (although they're hardly user visible).
Comment 4 Egmont Koblinger 2018-04-15 20:33:04 UTC
Another "solution" could be to drop the feature flags from the About dialog (it's probably too technical and not user friendly), and keep it for "gnome-terminal --version" only.
Comment 5 Michael Catanzaro 2018-04-15 22:00:41 UTC
(In reply to Egmont Koblinger from comment #4)
> Another "solution" could be to drop the feature flags from the About dialog
> (it's probably too technical and not user friendly), and keep it for
> "gnome-terminal --version" only.

Even better, it's pretty weird to have such technical details in the About dialog.
Comment 6 Christian Persch 2018-05-21 18:40:38 UTC
I have committed the patch except for the change to get_features(), and picked to 0-52 except for the string change.