GNOME Bugzilla – Bug 795233
Minor meson improvements
Last modified: 2018-04-16 05:46:45 UTC
A set of minor improvements to the meson port.
Created attachment 370888 [details] [review] meson: Fix introspection variable When VAPI support is enabled, meson checks that introspection is enabled. This is done by checking `enable_gir` variable. However, introspection support is set in the `enable_introspection` variable.
Created attachment 370889 [details] [review] meson: Bump meson version The `get_supported_arguments` helper function was added in meson 0.43, so bump meson's minimum version to 0.43.
Created attachment 370890 [details] [review] meson: Define check_gio_tls_src conditionally The `check_gio_tls_src` which contains the source code to test if the backend has TLs support should only be defined if `tls_check` is enabled.
Created attachment 370891 [details] [review] meson: Avoid a conditional expression when checking cURL The `HAVE_CURL` definition in the `config.h` file can use the conditional expression directly without a previous evaluation.
Created attachment 370892 [details] [review] meson: Avoid a conditional expression when checking Apache The conditional expression to set the value of `have_apache` is checked separately. However, it can be reduced to assign the value of the evaluation directly.
Created attachment 370893 [details] [review] meson: Take advantage of short-circuit evaluation Both `enable_gnome` and `enable_introspection` can take advantage of short-circuit evaluation to reduce meson parsing.
Created attachment 370894 [details] [review] meson: Avoid getting krb5_config option value early If GSSAPI is enabled and libsoup is not built using Microsoft compiler Kerberos can be used. Then the `krb5-config` binary is used. Until then is not necessary to check the `krb5_config` option.
All yours :)
Review of attachment 370888 [details] [review]: Good catch!
Review of attachment 370889 [details] [review]: LGTM
Review of attachment 370890 [details] [review]: Makes sense. Thanks!
Review of attachment 370891 [details] [review]: LGTM
Review of attachment 370892 [details] [review]: LGTM
Review of attachment 370893 [details] [review]: Nice!
Review of attachment 370893 [details] [review]: Correct the review status..
Review of attachment 370894 [details] [review]: Makes sense
Thank you Iñigo for your Meson patches!
attachment 370888 [details] [review] pushed as 3ac2959b - meson: Fix introspection variable attachment 370889 [details] [review] pushed as a1626e8e - meson: Bump meson version attachment 370890 [details] [review] pushed as 31a332fb - meson: Define check_gio_tls_src conditionally attachment 370891 [details] [review] pushed as a1a42371 - meson: Avoid a conditional expression when checking cURL attachment 370892 [details] [review] pushed as 3ea5ea75 - meson: Avoid a conditional expression when checking Apache attachment 370893 [details] [review] pushed as 46e17ef7 - meson: Take advantage of short-circuit evaluation attachment 370894 [details] [review] pushed as d6116d09 - meson: Avoid getting krb5_config option value early Thank you for your review Tomas!