GNOME Bugzilla – Bug 795228
kmssink: Update driver name for Xilinx DRM-KMS Driver
Last modified: 2018-07-25 12:02:27 UTC
Created attachment 370884 [details] [review] Updates xilinx DRM-KMS driver name The older xilinx DRM-KMS driver "xilinx_drm" is deprecated and a new driver "xlnx" supporting atomic DRM API has been implemented, so the attached patch addresses the same.
Review of attachment 370884 [details] [review]: ::: sys/kms/gstkmssink.c @@ +170,3 @@ static const char *drivers[] = { "i915", "radeon", "nouveau", "vmwgfx", "exynos", "amdgpu", "imx-drm", "rockchip", "atmel-hlcdc", "msm", + "xlnx", "vc4", I don't think it is a good idea to remove the old name, since we would be breaking the back compatibility. It is not expected that everybody will have the latest kernel.
Hi Victor, Thanks for the quick review, I didn't keep older driver because of below reasons : 1) As I understand only the new DRM driver i.e "xlnx" is being upstreamed (https://patchwork.kernel.org/patch/10162095/) to community and it was also confirmed by xilinx DRM driver owners that older DRM driver entry is not needed in kmssink. 2) The older DRM driver "xilinx_drm" is also disabled in xilinx kernel https://github.com/Xilinx/linux-xlnx/ ) now. Most of the users for xilinx board use yocto build which internally use a specific commit for gstreamer and kernel. So I guess if someone is still using older DRM from previous yocto build of xilinx they might be also using an older gstreamer release. Kindly let me know your opinion. Thanks, Devarsh
(In reply to Devarsh Thakkar from comment #2) > Hi Victor, > > Thanks for the quick review, I didn't keep older driver because of below > reasons : > > 1) As I understand only the new DRM driver i.e "xlnx" is being upstreamed > (https://patchwork.kernel.org/patch/10162095/) to community and it was also > confirmed by xilinx DRM driver owners that older DRM driver entry is not > needed in kmssink. > > 2) The older DRM driver "xilinx_drm" is also disabled in xilinx kernel > https://github.com/Xilinx/linux-xlnx/ ) now. Most of the users for xilinx > board use yocto build which internally use a specific commit for gstreamer > and kernel. So I guess if someone is still using older DRM from previous > yocto build of xilinx they might be also using an older gstreamer release. > > Kindly let me know your opinion. > > Thanks, > Devarsh I would keep both, adding a comment of the deprecation of the previous symbol. Please rebase your patch with current master.
Created attachment 371084 [details] [review] kmssink: Add new entry for Xilinx DRM Driver Hi Victor, As per review comment, rebased the patch on top of master branch, added a separate driver entry for xlnx and didn't delete old entry, also added a note describing the deprecation. Thanks, Devarsh
Attachment 371084 [details] pushed as d0575a0 - kmssink: Add new entry for Xilinx DRM Driver
I've ended changing a bit the patch. I believe the code is clearer. Thanks!
Added to 1.14