After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 795224 - wayland: don't poll if there are no pending frames
wayland: don't poll if there are no pending frames
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer-vaapi
unspecified
Other All
: Normal normal
: 1.14.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
: 772455 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2018-04-13 08:14 UTC by Michael Olbrich
Modified: 2018-04-20 05:07 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
wayland: don't poll if there are no pending frames (1.14 KB, patch)
2018-04-13 08:14 UTC, Michael Olbrich
none Details | Review
wayland: don't poll if there are no pending frames (1.14 KB, patch)
2018-04-18 06:58 UTC, Michael Olbrich
committed Details | Review

Description Michael Olbrich 2018-04-13 08:14:37 UTC
With the patch from bug 795220, applications can have their own event
queues in the same connection. Another thread that just loops over
wl_display_dispatch_queue() on another queue will immediately stall the
vaapisink.
Comment 1 Michael Olbrich 2018-04-13 08:14:44 UTC
Created attachment 370882 [details] [review]
wayland: don't poll if there are no pending frames

Otherwise the following poll may not return for an arbitrary amount of
time. This can happen if another wayland event queue has flushed and read
our events.
Comment 2 Víctor Manuel Jáquez Leal 2018-04-17 15:20:40 UTC
Review of attachment 370882 [details] [review]:

Heh! this is also very similar with bug 772455 but yours adds the missing wl_display_cancel_read(), which I believe resolves what I said in https://bugzilla.gnome.org/show_bug.cgi?id=772455#c5  ... nice!

nitpick: the indentation is not correct
Comment 3 Michael Olbrich 2018-04-18 06:58:14 UTC
Created attachment 371079 [details] [review]
wayland: don't poll if there are no pending frames

Indention fixed.
Comment 4 Víctor Manuel Jáquez Leal 2018-04-18 11:53:40 UTC
*** Bug 772455 has been marked as a duplicate of this bug. ***
Comment 5 Víctor Manuel Jáquez Leal 2018-04-18 12:12:27 UTC
Comment on attachment 371079 [details] [review]
wayland: don't poll if there are no pending frames

pushed as commit 1f71b5a5 attachment 371079 [details] [review] -  wayland: don't poll if there are no pending frames
Comment 6 Víctor Manuel Jáquez Leal 2018-04-18 12:55:57 UTC
branch 1.14

* daa2f65e wayland: don't poll if there are no pending frames

branch 1.12

* 1dc3c9e1 wayland: don't poll if there are no pending frames