After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 795200 - configure: Fix hard-coded enabled v4l2 probe on Linux/ARM
configure: Fix hard-coded enabled v4l2 probe on Linux/ARM
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
1.14.0
Other Linux
: Normal normal
: 1.14.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-04-12 15:06 UTC by Kirill Marinushkin
Modified: 2018-04-26 20:38 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
proposed patch (1.69 KB, patch)
2018-04-12 15:06 UTC, Kirill Marinushkin
committed Details | Review

Description Kirill Marinushkin 2018-04-12 15:06:09 UTC
Created attachment 370863 [details] [review]
proposed patch

Currently, enable_v4l2_probe is hard-coded to "yes" on linux, platforms
arm and aarch64. This even overrides the --disable-v4l2-probe argument.
As a result, it is impossible to disable v4l2_probe. It becomes a problem
for use-cases, when startup time is critical, because the v4l2_probe
feature increases the initialization time.

This commit makes the v4l2_probe feature configurable.
On linux, platforms arm and aarch64, the default value is still "yes".
But now it can be disabled by the --disable-v4l2-probe argument.
Comment 1 Nicolas Dufresne (ndufresne) 2018-04-26 20:37:33 UTC
commit ae1c2b0c674fe259b3850782a0c7aec2a7988809 (HEAD -> master, origin/master, origin/HEAD)
Author: Kirill Marinushkin <kmarinushkin@de.adit-jv.com>
Date:   Wed Apr 4 15:50:55 2018 +0200

    configure: Fix hard-coded enabled v4l2 probe on Linux/ARM
    
    Currently, enable_v4l2_probe is hard-coded to "yes" on linux, platforms
    arm and aarch64. This even overrides the --disable-v4l2-probe argument.
    As a result, it is impossible to disable v4l2_probe. It becomes a problem
    for use-cases, when startup time is critical, because the v4l2_probe
    feature increases the initialization time.
    
    This commit makes the v4l2_probe feature configurable.
    On linux, platforms arm and aarch64, the default value is still "yes".
    But now it can be disabled by the --disable-v4l2-probe argument.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=795200
Comment 2 Nicolas Dufresne (ndufresne) 2018-04-26 20:38:38 UTC
commit 4ad37153248b2c14b6d50a2210503040959a88a2 (HEAD -> 1.14)
Author: Kirill Marinushkin <kmarinushkin@de.adit-jv.com>
Date:   Wed Apr 4 15:50:55 2018 +0200

    configure: Fix hard-coded enabled v4l2 probe on Linux/ARM
    
    Currently, enable_v4l2_probe is hard-coded to "yes" on linux, platforms
    arm and aarch64. This even overrides the --disable-v4l2-probe argument.
    As a result, it is impossible to disable v4l2_probe. It becomes a problem
    for use-cases, when startup time is critical, because the v4l2_probe
    feature increases the initialization time.
    
    This commit makes the v4l2_probe feature configurable.
    On linux, platforms arm and aarch64, the default value is still "yes".
    But now it can be disabled by the --disable-v4l2-probe argument.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=795200
Comment 3 Nicolas Dufresne (ndufresne) 2018-04-26 20:38:47 UTC
Thanks !