Created attachment 370801 [details] [review]
rtpptdemux: set payload to caps inside gst_rtp_pt_demux_get_caps

Refactoring to remove duplicate code

Review of attachment 370800 [details] [review]:

Looks good

Review of attachment 370801 [details] [review]:

Just one little stylistic detail, otherwise it looks fine.

::: gst/rtpmanager/gstrtpptdemux.c
@@ +343,3 @@
+  } else if (sink_caps) {
+    have_ssrc = gst_structure_get_uint (
+        gst_caps_get_structure (sink_caps, 0), "ssrc", &ssrc);

Can you get the structure on line, then do the get_uint on a separate one, this is more the style

GstStructure *s = gst_caps_get_structure (sink_caps, 0);
have_ssrc = gst_structure_get_uint (s, "ssrc", &ssrc);

-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/issues/462.