Created attachment 370792 [details] [review]
API: gst_queue_array_peek_nth

Comment on attachment 370792 [details] [review]
API: gst_queue_array_peek_nth

Looks good to me. Small nitpicks:

- Function docs should perhaps also explicitly mention that the caller must check that the idx is valid, we don't handle out of bounds index access gracefully (but maybe we just should? Dunno.)

- run make update-exports to add the new API also to win32/common/libgstbase.def (while it still exists)

(In reply to Tim-Philipp Müller from comment #2)
> Comment on attachment 370792 [details] [review] [review]
> API: gst_queue_array_peek_nth
> 
> Looks good to me. Small nitpicks:
> 
> - Function docs should perhaps also explicitly mention that the caller must
> check that the idx is valid, we don't handle out of bounds index access
> gracefully (but maybe we just should? Dunno.)

g_return_val_if_fail() please

Created attachment 370862 [details] [review]
API: gst_queue_array_peek_nth

(In reply to Sebastian Dröge (slomo) from comment #3)
> g_return_val_if_fail() please

yes, that was already the case

(In reply to Tim-Philipp Müller from comment #2)
> Comment on attachment 370792 [details] [review] [review]
> - Function docs should perhaps also explicitly mention that the caller must
> check that the idx is valid, we don't handle out of bounds index access
> gracefully (but maybe we just should? Dunno.)

Updated the docs, we do handle out of bounds access as gracefully as we can already though :)

> 
> - run make update-exports to add the new API also to
> win32/common/libgstbase.def (while it still exists)

Done

Attachment 370862 [details] pushed as 03e27aa - API: gst_queue_array_peek_nth