After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 795115 - redundant fribidi dependency in pango.pc
redundant fribidi dependency in pango.pc
Status: RESOLVED OBSOLETE
Product: pango
Classification: Platform
Component: general
1.42.x
Other Linux
: Normal normal
: ---
Assigned To: pango-maint
pango-maint
Depends on:
Blocks:
 
 
Reported: 2018-04-09 23:03 UTC by kloczek
Modified: 2018-05-22 13:32 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description kloczek 2018-04-09 23:03:17 UTC
In https://github.com/GNOME/pango/commit/68cc13d04ed9d89609727f4448e5d2e08dd6626c fribidi has been added to list of pango devel dependncies.

Just checked and looks like none of the pango heder files uses any fribidi headers file.

$ grep -r fribidi $(echo $(pkgconf pango --variable=includedir)/pango-1.0)
/usr/include/pango-1.0/pango/pango-utils.h:/* A routine from fribidi that we either wrap or provide ourselves.

I cannot find any traces why it has been added.
What was the reason adding fribidi in pc file?
Comment 1 Peng Wu 2018-04-10 02:31:48 UTC
pango has switched from internal mini-fribidi to external fribidi library.

In order to support bidirectional text of Unicode 10.
Comment 2 Khaled Hosny 2018-04-10 23:22:13 UTC
That was to fix bug 794570. Should fribidi be moved to Requires.private instead?
Comment 3 kloczek 2018-04-10 23:32:12 UTC
Look one more time in te ticket  which you've mention.
This ticket is abut not dynamic linking but STATIC one.
In the ticket is "--static pango".
fribidi should be listed not in Requires but Requires.private.

From:
https://people.freedesktop.org/~dbn/pkg-config-guide.html

"Since pkg-config always exposes the link flags of the Requires libraries, these modules will become direct dependencies of the program. On the other hand, libraries from Requires.private will only be included when static linking. For this reason, it is usually only appropriate to add modules from the same package in Requires."

If someone is using static linking not Requites fields but Requires.private fields of the .pc files.

On compile and linking binary which will be using only dynamic pango library you don't even need to have installed fribidi devel resources.
Comment 4 Khaled Hosny 2018-04-10 23:37:40 UTC
The aggressive tone is really unwarranted!
Comment 5 kloczek 2018-04-10 23:46:52 UTC
??? what is so aggressive in quoting documentation?
Bugs happens and and pointing them it is not about personal fillings.
Please reply technically on quoted doc.

PS. If you have bad day just please postpone technical answer day or two (no rush).
Comment 6 GNOME Infrastructure Team 2018-05-22 13:32:05 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/pango/issues/305.