GNOME Bugzilla – Bug 795115
redundant fribidi dependency in pango.pc
Last modified: 2018-05-22 13:32:05 UTC
In https://github.com/GNOME/pango/commit/68cc13d04ed9d89609727f4448e5d2e08dd6626c fribidi has been added to list of pango devel dependncies. Just checked and looks like none of the pango heder files uses any fribidi headers file. $ grep -r fribidi $(echo $(pkgconf pango --variable=includedir)/pango-1.0) /usr/include/pango-1.0/pango/pango-utils.h:/* A routine from fribidi that we either wrap or provide ourselves. I cannot find any traces why it has been added. What was the reason adding fribidi in pc file?
pango has switched from internal mini-fribidi to external fribidi library. In order to support bidirectional text of Unicode 10.
That was to fix bug 794570. Should fribidi be moved to Requires.private instead?
Look one more time in te ticket which you've mention. This ticket is abut not dynamic linking but STATIC one. In the ticket is "--static pango". fribidi should be listed not in Requires but Requires.private. From: https://people.freedesktop.org/~dbn/pkg-config-guide.html "Since pkg-config always exposes the link flags of the Requires libraries, these modules will become direct dependencies of the program. On the other hand, libraries from Requires.private will only be included when static linking. For this reason, it is usually only appropriate to add modules from the same package in Requires." If someone is using static linking not Requites fields but Requires.private fields of the .pc files. On compile and linking binary which will be using only dynamic pango library you don't even need to have installed fribidi devel resources.
The aggressive tone is really unwarranted!
??? what is so aggressive in quoting documentation? Bugs happens and and pointing them it is not about personal fillings. Please reply technically on quoted doc. PS. If you have bad day just please postpone technical answer day or two (no rush).
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/pango/issues/305.