After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 795111 - XMLRPC test fails with PHP ≥ 7.2
XMLRPC test fails with PHP ≥ 7.2
Status: RESOLVED FIXED
Product: libsoup
Classification: Core
Component: Misc
2.62.x
Other Linux
: Normal normal
: ---
Assigned To: libsoup-maint@gnome.bugs
libsoup-maint@gnome.bugs
Depends on:
Blocks:
 
 
Reported: 2018-04-09 19:53 UTC by Jan Alexander Steffens (heftig)
Modified: 2018-04-17 08:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
[PATCH] xmlrpc-server.php: Don't try to count NULL params (1.13 KB, patch)
2018-04-09 19:55 UTC, Jan Alexander Steffens (heftig) 		committed Details | Review
xmlrpc-server.php: Don't try to count NULL params (1.04 KB, patch)
2018-04-17 08:05 UTC, Tomas Popela 		committed Details | Review

Description Jan Alexander Steffens (heftig) 2018-04-09 19:53:10 UTC 
Trying to count something uncountable causes PHP ≥7.2 to emit a warning before returning zero.

I assume that the ping() function's $params is NULL when there are no parameters.
Comment 1 Jan Alexander Steffens (heftig) 2018-04-09 19:55:17 UTC 
Created attachment 370708 [details] [review]
[PATCH] xmlrpc-server.php: Don't try to count NULL params
Comment 2 Claudio Saavedra 2018-04-10 12:38:39 UTC 
Review of attachment 370708 [details] [review]:

That seems a safe assumption. Please push also to the stable branch.
Comment 3 Tomas Popela 2018-04-17 08:05:08 UTC 
Comment on attachment 370708 [details] [review]
[PATCH] xmlrpc-server.php: Don't try to count NULL params

The following fix has been pushed:
d2a6c20 xmlrpc-server.php: Don't try to count NULL params
Comment 4 Tomas Popela 2018-04-17 08:05:14 UTC 
Created attachment 371014 [details] [review]
xmlrpc-server.php: Don't try to count NULL params

Trying to count something uncountable causes PHP ≥7.2 to emit a warning
before returning zero.

I assume that the ping() function's $params is NULL when there are no
parameters.