After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 795099 - Fix bug in Gst.Pad.set_query_function
Fix bug in Gst.Pad.set_query_function
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-python
git master
Other Linux
: Normal normal
: 1.14.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-04-09 13:27 UTC by Mike C. Fletcher
Modified: 2018-04-09 17:19 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch to fix the function passed into the low-level operation. (1.09 KB, patch)
2018-04-09 13:27 UTC, Mike C. Fletcher
none Details | Review

Description Mike C. Fletcher 2018-04-09 13:27:51 UTC
Created attachment 370689 [details] [review]
Patch to fix the function passed into the low-level operation.

In Gst.Pad.set_query_function the wrong method is specified when passed to the underlying C function. Also, in set_query_function_full the udata paramter is ignored/dropped.

The bug results in failures attempting to call the chain function in _chain_override and in at least a few cases in segfaults of applications.
Comment 1 Mike C. Fletcher 2018-04-09 17:16:28 UTC
thiblahute apparently pushed a fix for this already.
Comment 2 Thibault Saunier 2018-04-09 17:19:02 UTC
commit 861a67bde6c9460a60cfe6745a0e5a2d83f49621 (HEAD -> master, origin/master, origin/HEAD)
Author: Thibault Saunier <tsaunier@igalia.com>
Date:   Sat Apr 7 21:46:07 2018 -0300

    overrides: Fix mixup between query function and chain one